Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposal: x/arch/arm64/arm64asm: Export imm field in MemImmediate #57684

Open
yardenlaif opened this issue Jan 8, 2023 · 4 comments
Open

proposal: x/arch/arm64/arm64asm: Export imm field in MemImmediate #57684

yardenlaif opened this issue Jan 8, 2023 · 4 comments
Labels
Proposal
Milestone
Proposal

Comments

@yardenlaif
Copy link

The MemImmediate struct in arm64asm is as follows:

type MemImmediate struct {
    Base RegSP
    Mode AddrMode
    imm int32
}

My proposal is to export the imm field:

type MemImmediate struct {
    Base RegSP
    Mode AddrMode
    Imm int32
}

This would allow any external use of this API to access the imm field, which seems necessary.
@gopherbot gopherbot added this to the Proposal milestone Jan 8, 2023
@yardenlaif
Copy link
Author

I just saw #51517 (comment)
Since this thread seems to be inactive, and changing only MemImmediate to add Reg field and export imm seems relatively simple, is there a chance to just make those adjustments?

@ianlancetaylor
Copy link
Contributor

CC @cherrymui

@cherrymui
Copy link
Member

I assume this is for the x/arch/arm64/arm64asm package? Could you confirm or clarify? Thanks.

This sounds like one step of #51517 ? One step at a time sounds fine to me.

@yardenlaif
Copy link
Author

Yes, this is for x/arch/arm64/arm64asm, and it's one step of #51517.
In that case, I'd love to be the one to create a PR for it.

@cherrymui cherrymui changed the title proposal: x/arch: Export imm field in MemImmediate proposal: x/arch/arm64/arm64asm: Export imm field in MemImmediate Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Proposal
Projects
Proposals
Status: Incoming
Milestone
Proposal
Development

No branches or pull requests
4 participants
@ianlancetaylor @gopherbot @cherrymui @yardenlaif