x/tools/gopls: make file size limit configurable #57660
Labels
FrozenDueToAge
gopls
Issues related to the Go language server, gopls.
Tools
This label describes issues relating to any tools in the x/tools repository.
WaitingForInfo
Issue is not actionable because of missing required information, which needs to be provided.
Milestone
gopls version
just says it's "master", which is commit 36bd3db
go env
N/A
What did you do?
have bloated code but a very fast computer
What did you expect to see?
semantic highlighting anyway
What did you see instead?
an arbitrary file size limit on semantic tokens which seems very small to me
Editor and settings
vscode
Logs
N/A
Basically: I think
maxFullFileSize
should be configurable.Ideally, the people doing the vscode plugin would start using ranges and do semantic token queries on ranges rather than on the full file. But since they don't seem to be doing that, it would be nice to have a setting that could be exposed to allow people who need slightly larger files highlighted to do that.
(Unrelatedly, I just build my own copy, and that used to work, but stopped for reasons I can't figure out, but that got me to thinking "hey why is this a hard-coded limit anyway".)
The text was updated successfully, but these errors were encountered: