Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/internal/robustio: build error on plan9 since CL 458200 due to missing definition for getFileID #57642

Closed
bcmills opened this issue Jan 5, 2023 · 3 comments
Closed

x/tools/internal/robustio: build error on plan9 since CL 458200 due to missing definition for getFileID #57642

bcmills opened this issue Jan 5, 2023 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Plan9 Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Jan 5, 2023 

# golang.org/x/tools/internal/robustio
internal/robustio/robustio.go:65:58: undefined: getFileID
FAIL	golang.org/x/tools/internal/robustio [build failed]

A plan9 definition for that function appears to have been omitted in CL 458200 (attn @alandonovan @timothy-king).
@bcmills bcmills added OS-Plan9 NeedsFix The path to resolution is known, but the work has not been done. labels Jan 5, 2023
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Jan 5, 2023
@gopherbot gopherbot added this to the Unreleased milestone Jan 5, 2023
@bcmills
Copy link
Contributor Author

bcmills commented Jan 5, 2023

(CC @golang/plan9)

@adonovan
Copy link
Member

adonovan commented Jan 5, 2023

see https://go.dev/cl/460855

@gopherbot
Copy link

Change https://go.dev/cl/460855 mentions this issue: internal/robustio: add Plan9 support to FileID

@golang golang locked and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Plan9 Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bcmills @adonovan @gopherbot