Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: revisit line directive support #57640

Closed
findleyr opened this issue Jan 5, 2023 · 2 comments
Closed

x/tools/gopls: revisit line directive support #57640

findleyr opened this issue Jan 5, 2023 · 2 comments
Assignees
@pjweinb
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.12.0

Comments

@findleyr
Copy link
Contributor

findleyr commented Jan 5, 2023

Following our removal of line directive support from the core of gopls, we should re-evaluate whether or not there are selected areas where we can / should expand positions to related positions (e.g. duplicating or re-mapping diagnostics, handling jump-to-definition requests, etc.).
@findleyr findleyr added this to the gopls/v0.12.0 milestone Jan 5, 2023
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jan 5, 2023
@adonovan adonovan added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Jan 12, 2023
@findleyr findleyr assigned findleyr and pjweinb and unassigned findleyr Mar 23, 2023
@findleyr
Copy link
Contributor Author

@pjweinb should we close this now that #59124 is fixes?

@pjweinb
Copy link

pjweinb commented Mar 31, 2023

yes

@pjweinb pjweinb closed this as completed Mar 31, 2023
@golang golang locked and limited conversation to collaborators Mar 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pjweinb pjweinb

Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.12.0
Development

No branches or pull requests
4 participants
@pjweinb @adonovan @gopherbot @findleyr