Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/watchflakes: don't reopen closed issues #57632

Open
findleyr opened this issue Jan 5, 2023 · 4 comments
Open

x/build/cmd/watchflakes: don't reopen closed issues #57632

findleyr opened this issue Jan 5, 2023 · 4 comments
Assignees
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@findleyr
Copy link
Contributor

findleyr commented Jan 5, 2023

I've recently encountered several instances where watchflakes reopens closed issues, due to a test flake at a commit that actually precedes the fix (example https://go.dev/issue/57512#issuecomment-1371430442).

Watchflakes shouldn't reopen the issue in these cases. Posting to the issue seems fine, but perhaps with a message "not reopening as commit precedes the issue closure".

CC @rsc @cherrymui @bcmills

@heschi heschi added the NeedsFix The path to resolution is known, but the work has not been done. label Jan 5, 2023
@heschi heschi added this to the Unreleased milestone Jan 5, 2023
@heschi heschi changed the title watchflakes: don't reopen issues when the flake commit time precedes close time x/build/cmd/watchflakes: don't reopen issues when the flake commit time precedes close time Jan 5, 2023
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jan 5, 2023
@cherrymui cherrymui self-assigned this Jan 9, 2023
@cherrymui
Copy link
Member

I made a change in my local copy of watchflakes so it won't reopen in this case. #57900 (comment) posted but not reopened. Seems working.
(I forgot to add the "not reopening" message...)

@findleyr
Copy link
Contributor Author

@cherrymui watchflakes appears to have just reopened a bunch of issues. For example this one:
https://go.dev/issue/57888#event-8356641212

I think the reason is that these were closed as a dupe, before the actual fix. Is that right?

@bcmills
Copy link
Contributor

bcmills commented Jul 11, 2023

I've noticed that, because the watchflakes patterns by default don't have a date bound, watchflakes tends to reopen old issues for unrelated new regressions, as in #60368 (comment).

If you know to look for it, you can manually edit the pattern to add date <= <date of fix CL> when you close the issue. But that step is a little subtle to remember, and it shouldn't be necessary to manually edit the pattern for every single issue we fix.

I think a better behavior for closed issues would probably be:

  1. Continue to post matches, without reopening the issue, for failures where either the go commit timestamp or the subrepo commit timestamp is older than the timestamp at which the issue was last closed.
  2. Never post a match for a log where both the go commit timestamp and the subrepo commit timestamp (if any) are after the timestamp at which the issue was last closed.
    • Instead, file a new issue with a default pattern. If it turns out to be a duplicate, we can manually reopen the old issue, close the new one as a duplicate, and remove the duplicate from the “Test Flakes” project, which should cause the new logs to once again be posted to the old (reopened) issue.

@ianlancetaylor
Copy link
Contributor

Just a note: perhaps the new issue should mention the existing closed issue, to make it easier for people to notice the possible duplication.

@bcmills bcmills changed the title x/build/cmd/watchflakes: don't reopen issues when the flake commit time precedes close time x/build/cmd/watchflakes: don't reopen issues Aug 21, 2023
@bcmills bcmills changed the title x/build/cmd/watchflakes: don't reopen issues x/build/cmd/watchflakes: don't reopen closed issues Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

6 participants