Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/lsp/filecache: build broken on plan9 as of CL 443099 #57629

Closed
bcmills opened this issue Jan 5, 2023 · 2 comments
Closed

x/tools/gopls/internal/lsp/filecache: build broken on plan9 as of CL 443099 #57629

bcmills opened this issue Jan 5, 2023 · 2 comments
Assignees
@adonovan
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. OS-Plan9 Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Jan 5, 2023

https://go.dev/cl/443099 added a use of syscall.Utimes on non-Windows platforms.
Unfortunately, syscall.Utimes is not defined on plan9.

https://build.golang.org/log/3e3104c6acd8231d8bee91ca6d945192aec4c108:

# golang.org/x/tools/gopls/internal/lsp/filecache
internal/lsp/filecache/setfiletime_unix.go:24:17: undefined: syscall.Utimes
…
FAIL	golang.org/x/tools/gopls/test [build failed]
FAIL	golang.org/x/tools/gopls/test/debug [build failed]
FAIL
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jan 5, 2023
@gopherbot gopherbot added this to the Unreleased milestone Jan 5, 2023
@bcmills bcmills added OS-Plan9 NeedsFix The path to resolution is known, but the work has not been done. and removed gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. labels Jan 5, 2023
@bcmills bcmills added gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. labels Jan 5, 2023
@gopherbot
Copy link

Change https://go.dev/cl/460816 mentions this issue: gopls/internal/lsp/filecache: add Plan9 impl of setFileTime

@gopherbot
Copy link

Change https://go.dev/cl/460855 mentions this issue: internal/robustio: add Plan9 support to FileID

@golang golang locked and limited conversation to collaborators Jan 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@adonovan adonovan

Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. OS-Plan9 Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bcmills @adonovan @gopherbot