Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/exp/constraints: TestFailure fails on Go tip after compiler improved error messages #57615

Closed
dmitshur opened this issue Jan 4, 2023 · 1 comment
Assignees
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Jan 4, 2023

CL 460396 improved error messages for constraint errors. It seems TestFailure in x/exp/constraints currently depends on the old text containing the old "implements" word, and has started to fail as a result (on Go tip commits only, of course):

--- FAIL: TestFailure (0.04s)
    constraints_test.go:106: /workdir/go/bin/go mod tidy:
        go: found golang.org/x/exp/constraints in golang.org/x/exp v0.0.0-00010101000000-000000000000
    --- FAIL: TestFailure/testComplex_4 (0.06s)
        constraints_test.go:150: # command-line-arguments
            ./go4.go:14:19: float64 does not satisfy constraints.Complex (float64 missing in ~complex64 | ~complex128)
        constraints_test.go:153: output does not include "does not implement"
[...]
FAIL
FAIL	golang.org/x/exp/constraints	0.129s

(See https://build.golang.org/log/7f6d2fc6016a563b18ee95e527b28681ac44076b or https://build.golang.org/?repo=golang.org%2fx%2fexp.)

CC @griesemer.

@dmitshur dmitshur added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels Jan 4, 2023
@dmitshur dmitshur added this to the Unreleased milestone Jan 4, 2023
@griesemer griesemer self-assigned this Jan 4, 2023
@gopherbot
Copy link

Change https://go.dev/cl/460460 mentions this issue: constraints: update test to match old and new constraint error messages

@golang golang locked and limited conversation to collaborators Jan 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

3 participants