Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: TestTCPSelfConnect failures #57609

Closed
gopherbot opened this issue Jan 4, 2023 · 3 comments
Closed

net: TestTCPSelfConnect failures #57609

gopherbot opened this issue Jan 4, 2023 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.21

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "net" && test == "TestTCPSelfConnect"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestTCPSelfConnect (0.44s)
    tcpsock_test.go:655: Dial 127.0.0.1:13953 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:32484 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:1431 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:29487 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:20884 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:39729 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:48676 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:38779 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:29440 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:46229 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:44613 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:7107 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:3422 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:15917 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:41220 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:27333 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:40879 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:43747 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:32553 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:44049 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:10361 should fail

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 4, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net" && test == "TestTCPSelfConnect"
2022-12-07 16:56 openbsd-amd64-72 go@e57e673e net.TestTCPSelfConnect (log) 
--- FAIL: TestTCPSelfConnect (0.44s)
    tcpsock_test.go:655: Dial 127.0.0.1:13953 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:32484 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:1431 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:29487 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:20884 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:39729 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:48676 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:38779 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:29440 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:46229 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:44613 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:7107 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:3422 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:15917 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:41220 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:27333 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:40879 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:43747 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:32553 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:44049 should fail
    tcpsock_test.go:655: Dial 127.0.0.1:10361 should fail

— watchflakes

@bcmills bcmills added this to the Backlog milestone Jan 5, 2023
@bcmills
Copy link
Contributor

bcmills commented Jan 5, 2023

At the very least, the failure message in this test looks bogus: it's logging a different port for each Dial attempt.

But this test looks like it is inherently flaky: it is opening a port, then closing that port, and finally dialing it and expecting the dial to fail — but nothing prevents the port from being reused in the meantime!

(CC @ianlancetaylor @neild for net)

@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels Jan 5, 2023
@bcmills bcmills self-assigned this Jan 5, 2023
@bcmills bcmills modified the milestones: Backlog, Go1.21 Jan 5, 2023
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 5, 2023
@bcmills bcmills mentioned this issue Jan 5, 2023
Closed
@bcmills
Copy link
Contributor

bcmills commented Jan 5, 2023

Duplicate of #18290

@bcmills bcmills marked this as a duplicate of #18290 Jan 5, 2023
@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Jan 5, 2023
@bcmills bcmills removed their assignment Jan 20, 2023
@golang golang locked and limited conversation to collaborators Jan 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.21
Development

No branches or pull requests
2 participants
@bcmills @gopherbot