Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: TestContentTypeWithVariousSources failures #57606

Open
gopherbot opened this issue Jan 4, 2023 · 4 comments
Open

net/http: TestContentTypeWithVariousSources failures #57606

gopherbot opened this issue Jan 4, 2023 · 4 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@gopherbot
Copy link

gopherbot commented Jan 4, 2023 •
edited by bcmills 

#!watchflakes
post <- pkg == "net/http" && test == "TestContentTypeWithVariousSources" && `timeout waiting for .* frames`

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestContentTypeWithVariousSources (0.00s)
    --- FAIL: TestContentTypeWithVariousSources/h2 (5.52s)
        --- FAIL: TestContentTypeWithVariousSources/h2/write_one_byte_at_a_time (3.25s)
            clientserver_test.go:210: server log: timeout waiting for SETTINGS frames from 127.0.0.1:61917
            sniff_test.go:236: Get: Get "https://127.0.0.1:61916": unexpected EOF

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 4, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestContentTypeWithVariousSources"
2022-12-01 21:00 freebsd-arm-paulzhol go@93587d35 net/http.TestContentTypeWithVariousSources (log) 
--- FAIL: TestContentTypeWithVariousSources (0.00s)
    --- FAIL: TestContentTypeWithVariousSources/h2 (5.52s)
        --- FAIL: TestContentTypeWithVariousSources/h2/write_one_byte_at_a_time (3.25s)
            clientserver_test.go:210: server log: timeout waiting for SETTINGS frames from 127.0.0.1:61917
            sniff_test.go:236: Get: Get "https://127.0.0.1:61916": unexpected EOF

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Jan 6, 2023

The timeout in question appears to be http2firstSettingsTimeout:
https://cs.opensource.google/go/go/+/master:src/net/http/h2_bundle.go;l=3795;drc=119f679a3bd2e60cfc990920f82fd1a5cb006f4c
https://cs.opensource.google/go/go/+/master:src/net/http/h2_bundle.go;l=4711;drc=119f679a3bd2e60cfc990920f82fd1a5cb006f4c

It isn't clear to me whether that timeout is arbitrary or actually defined or recommended in the HTTP/2 RFCs (maybe @neild knows?).

I also seem to recall some discussion with @paulzhol about upgrading the builder to avoid scheduling stalls, but I can't find it now. 😅

@paulzhol
Copy link
Member

paulzhol commented Jan 8, 2023

I've upgraded the builder a while back (six months?) the dashboard just got updated for it recently http://golang.org/cl/420354.
And the unexpected EOF makes me think this could be the RST theory of #57476 (comment).

@gopherbot

This comment was marked as off-topic.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Test Flakes
Status: No status
Milestone
No milestone
Development

No branches or pull requests
3 participants
@paulzhol @bcmills @gopherbot