Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: TestKeepAliveFinalChunkWithEOF failures #57604

Closed
gopherbot opened this issue Jan 4, 2023 · 4 comments
Closed

net/http: TestKeepAliveFinalChunkWithEOF failures #57604

gopherbot opened this issue Jan 4, 2023 · 4 comments
Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.21

Comments

@gopherbot
Copy link

gopherbot commented Jan 4, 2023 •
edited by bcmills 

#!watchflakes
post <- pkg == "net/http" && test == "TestKeepAliveFinalChunkWithEOF" && `connection not reused`

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestKeepAliveFinalChunkWithEOF (0.15s)
    serve_test.go:1220: connection not reused
2022/11/30 11:10:56 http: TLS handshake error from 127.0.0.1:51048: EOF
2022/11/30 11:10:56 http: TLS handshake error from 127.0.0.1:51049: EOF

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 4, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestKeepAliveFinalChunkWithEOF"
2022-11-30 18:33 darwin-amd64-race go@9f443332 net/http.TestKeepAliveFinalChunkWithEOF (log) 
--- FAIL: TestKeepAliveFinalChunkWithEOF (0.15s)
    serve_test.go:1220: connection not reused
2022/11/30 11:10:56 http: TLS handshake error from 127.0.0.1:51048: EOF
2022/11/30 11:10:56 http: TLS handshake error from 127.0.0.1:51049: EOF

— watchflakes

@bcmills bcmills mentioned this issue Jan 6, 2023
Closed
@bcmills bcmills added this to the Backlog milestone Jan 6, 2023
@bcmills
Copy link
Contributor

bcmills commented Jan 6, 2023

(CC @neild; this is in the cluster of “connection reuse” failures)

@gopherbot

This comment was marked as off-topic.

Sign in to view
@bcmills bcmills mentioned this issue Apr 7, 2023
Closed
@gopherbot
Copy link
Author

Change https://go.dev/cl/483116 mentions this issue: net/http: wait forever for write results in tests

@dmitshur dmitshur modified the milestones: Backlog, Go1.21 May 24, 2023
@dmitshur dmitshur added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Status: Done
Milestone
Go1.21
Development

No branches or pull requests
3 participants
@dmitshur @bcmills @gopherbot