Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: TestClientInsecureTransport failures with timeout waiting for logged error #57599

Closed
gopherbot opened this issue Jan 4, 2023 · 11 comments
Closed

net/http: TestClientInsecureTransport failures with timeout waiting for logged error #57599

gopherbot opened this issue Jan 4, 2023 · 11 comments
Assignees
@bcmills
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin
Milestone
Go1.22

Comments

@gopherbot
Copy link

gopherbot commented Jan 4, 2023 •
edited by bcmills 

#!watchflakes
post <- pkg == "net/http" && test == "TestClientInsecureTransport" && `timeout waiting for logged error`

Issue created automatically to collect these failures.

Example (log):

2022/12/05 04:24:00 httptest.Server blocked in Close after 5 seconds, waiting for connections:
  *net.TCPConn 0xc00033a2b0 127.0.0.1:50159 in state active
--- FAIL: TestClientInsecureTransport (0.00s)
    --- FAIL: TestClientInsecureTransport/h2 (15.74s)
        client_test.go:860: timeout waiting for logged error
2022/12/05 04:24:18 httptest.Server blocked in Close after 5 seconds, waiting for connections:

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 4, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestClientInsecureTransport"
2022-11-19 01:19 darwin-amd64-13 go@c6cdfd88 net/http.TestClientInsecureTransport (log) 
2022/12/05 04:24:00 httptest.Server blocked in Close after 5 seconds, waiting for connections:
  *net.TCPConn 0xc00033a2b0 127.0.0.1:50159 in state active
--- FAIL: TestClientInsecureTransport (0.00s)
    --- FAIL: TestClientInsecureTransport/h2 (15.74s)
        client_test.go:860: timeout waiting for logged error
2022/12/05 04:24:18 httptest.Server blocked in Close after 5 seconds, waiting for connections:
2022-12-19 21:44 darwin-amd64-11_0 go@7683c71a net/http.TestClientInsecureTransport (log) 
2022/12/20 00:31:30 httptest.Server blocked in Close after 5 seconds, waiting for connections:
  *net.TCPConn 0xc0001b9950 127.0.0.1:50593 in state active
--- FAIL: TestClientInsecureTransport (5.98s)
    client_test.go:882: timeout waiting for logged error
2022-12-29 23:36 darwin-amd64-10_15 go@db36eca3 net/http.TestClientInsecureTransport (log) 
--- FAIL: TestClientInsecureTransport (0.00s)
    --- FAIL: TestClientInsecureTransport/h2 (5.43s)
        client_test.go:860: timeout waiting for logged error
    --- FAIL: TestClientInsecureTransport/https1 (5.47s)
        client_test.go:860: timeout waiting for logged error

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Jan 6, 2023

(attn @neild)

@bcmills
Copy link
Contributor

bcmills commented Jan 6, 2023

Curious that these are all on darwin builders. 🤔

@bcmills bcmills added this to the Backlog milestone Jan 10, 2023
@bcmills bcmills mentioned this issue Jan 17, 2023
Closed
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestClientInsecureTransport"
2023-01-19 22:42 darwin-amd64-13 go@47a0d467 net/http.TestClientInsecureTransport (log) 
--- FAIL: TestClientInsecureTransport (0.00s)
    --- FAIL: TestClientInsecureTransport/https1 (12.49s)
        client_test.go:860: timeout waiting for logged error
    --- FAIL: TestClientInsecureTransport/h2 (12.47s)
        client_test.go:860: timeout waiting for logged error

— watchflakes

@gopherbot

This comment was marked as off-topic.

Sign in to view
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestClientInsecureTransport" && `timeout waiting for logged error`
2023-02-14 17:25 darwin-amd64-nocgo go@00b256e9 net/http.TestClientInsecureTransport (log) 
2023/02/15 02:39:18 http: TLS handshake error from 127.0.0.1:50986: EOF
2023/02/15 02:39:18 http: TLS handshake error from 127.0.0.1:50991: EOF
2023/02/15 02:39:18 http: TLS handshake error from 127.0.0.1:50997: read tcp 127.0.0.1:50983->127.0.0.1:50997: read: connection reset by peer
2023/02/15 02:39:18 httptest.Server blocked in Close after 5 seconds, waiting for connections:
  *net.TCPConn 0xc000012010 127.0.0.1:50578 in state active
2023/02/15 02:39:18 httptest.Server blocked in Close after 5 seconds, waiting for connections:
  *net.TCPConn 0xc000370028 127.0.0.1:50582 in state active
--- FAIL: TestClientInsecureTransport (12.68s)
    client_test.go:882: timeout waiting for logged error
2023/02/15 02:39:31 http: TLS handshake error from 127.0.0.1:51098: read tcp 127.0.0.1:51089->127.0.0.1:51098: use of closed network connection
2023-02-15 21:45 darwin-amd64-12_0 go@85ded85b net/http.TestClientInsecureTransport (log) 
--- FAIL: TestClientInsecureTransport (0.00s)
    --- FAIL: TestClientInsecureTransport/https1 (9.09s)
        client_test.go:860: timeout waiting for logged error

— watchflakes

@bcmills bcmills changed the title net/http: TestClientInsecureTransport failures net/http: TestClientInsecureTransport failures with timeout waiting for logged error Mar 14, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestClientInsecureTransport" && `timeout waiting for logged error`
2023-04-05 00:47 darwin-amd64-13 go@508f445a net/http.TestClientInsecureTransport (log) 
--- FAIL: TestClientInsecureTransport (0.00s)
    --- FAIL: TestClientInsecureTransport/https1 (19.22s)
        client_test.go:860: timeout waiting for logged error
    --- FAIL: TestClientInsecureTransport/h2 (19.22s)
        client_test.go:860: timeout waiting for logged error
panic: test timed out after 3m0s
running tests:
	TestMaxBytesHandler (2m59s)
	TestMaxBytesHandler/max_size_100_request_size_1000 (2m57s)
	TestMaxBytesHandler/max_size_100_request_size_1000/h1 (2m48s)

goroutine 21410 [running]:
panic({0x1423280?, 0xc000134b70?})
	/tmp/buildlet/go/src/runtime/panic.go:1016 +0x3ac fp=0xc0005b2f10 sp=0xc0005b2e60 pc=0x103460c
testing.(*M).startAlarm.func1()
	/tmp/buildlet/go/src/testing/testing.go:2260 +0x3b9 fp=0xc0005b2fe0 sp=0xc0005b2f10 pc=0x10f7939
runtime.goexit()
	/tmp/buildlet/go/src/runtime/asm_amd64.s:1650 +0x1 fp=0xc0005b2fe8 sp=0xc0005b2fe0 pc=0x1069761
created by time.goFunc
	/tmp/buildlet/go/src/time/sleep.go:176 +0x2d

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestClientInsecureTransport" && `timeout waiting for logged error`
2023-05-08 16:39 darwin-amd64-13 go@77b1f23a net/http.TestClientInsecureTransport (log) 
--- FAIL: TestClientInsecureTransport (0.00s)
    --- FAIL: TestClientInsecureTransport/https1 (12.58s)
        client_test.go:860: timeout waiting for logged error
    --- FAIL: TestClientInsecureTransport/h2 (12.43s)
        client_test.go:860: timeout waiting for logged error

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestClientInsecureTransport" && `timeout waiting for logged error`
2023-05-09 12:49 darwin-amd64-13 go@59d19ba7 net/http.TestClientInsecureTransport (log) 
--- FAIL: TestClientInsecureTransport (0.00s)
    --- FAIL: TestClientInsecureTransport/https1 (7.35s)
        client_test.go:860: timeout waiting for logged error
    --- FAIL: TestClientInsecureTransport/h2 (7.20s)
        client_test.go:860: timeout waiting for logged error

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestClientInsecureTransport" && `timeout waiting for logged error`
2023-11-02 04:17 darwin-amd64-12_0 go@11677d98 net/http.TestClientInsecureTransport (log) 
2023/11/01 23:32:08 httptest.Server blocked in Close after 5 seconds, waiting for connections:
  *net.TCPConn 0xc00023a290 127.0.0.1:50361 in state active
2023/11/01 23:32:08 httptest.Server blocked in Close after 5 seconds, waiting for connections:
  *tls.Conn 0xc000027500 127.0.0.1:50376 in state idle
--- FAIL: TestClientInsecureTransport (0.00s)
    --- FAIL: TestClientInsecureTransport/h2 (23.31s)
        client_test.go:860: timeout waiting for logged error
    --- FAIL: TestClientInsecureTransport/https1 (23.38s)
        client_test.go:860: timeout waiting for logged error

— watchflakes

@gopherbot
Copy link
Author

Change https://go.dev/cl/539436 mentions this issue: net/http: remove arbitrary timeouts in tests of Server.ErrorLog

@bcmills bcmills modified the milestones: Backlog, Go1.22 Nov 2, 2023
@bcmills bcmills self-assigned this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bcmills bcmills

Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin
Projects
Test Flakes
Status: Done
Milestone
Go1.22
Development

No branches or pull requests
2 participants
@bcmills @gopherbot