Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: TestScript shutdown stall due to blocked hgHandler #57597

Closed
gopherbot opened this issue Jan 4, 2023 · 2 comments
Closed

cmd/go: TestScript shutdown stall due to blocked hgHandler #57597

gopherbot opened this issue Jan 4, 2023 · 2 comments
Assignees
@bcmills
Labels
FrozenDueToAge GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.21

Comments

@gopherbot
Copy link

gopherbot commented Jan 4, 2023 •
edited by bcmills 

#!watchflakes
post <- pkg == "cmd/go" && test == "TestScript" && `httptest\.Server blocked in Close` && `^cmd/go/internal/vcweb\.\(\*hgHandler\)\.Handler`

Issue created automatically to collect these failures.

Example (log):

vcs-test.golang.org rerouted to http://127.0.0.1:33265
https://vcs-test.golang.org rerouted to https://127.0.0.1:38441
go test proxy running at GOPROXY=http://127.0.0.1:33193/mod
2022/11/18 19:00:39 http: TLS handshake error from 127.0.0.1:58762: read tcp 127.0.0.1:38441->127.0.0.1:58762: read: connection reset by peer
2022/11/18 19:00:39 http: TLS handshake error from 127.0.0.1:58738: EOF
2022/11/18 19:00:39 http: TLS handshake error from 127.0.0.1:58754: EOF
2022/11/18 19:38:47 httptest.Server blocked in Close after 5 seconds, waiting for connections:
  *net.TCPConn 0xc0001ac2f8 127.0.0.1:37976 in state active
panic: test timed out after 45m0s
running tests:
	TestScript (44m59s)

goroutine 20353 [running]:
panic({0xe705a0, 0xc0007fc040})
	/workdir/go/src/runtime/panic.go:987 +0x3bb fp=0xc00057ff18 sp=0xc00057fe58 pc=0x44aa9b
testing.(*M).startAlarm.func1()
	/workdir/go/src/testing/testing.go:2240 +0x219 fp=0xc00057ffe0 sp=0xc00057ff18 pc=0x5bdb79
runtime.goexit()
	/workdir/go/src/runtime/asm_amd64.s:1598 +0x1 fp=0xc00057ffe8 sp=0xc00057ffe0 pc=0x482e41
created by time.goFunc
	/workdir/go/src/time/sleep.go:176 +0x48

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 4, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go" && test == ""
2022-11-18 17:59 linux-amd64-longtest-race go@b2faff18 cmd/go (log) 
vcs-test.golang.org rerouted to http://127.0.0.1:33265
https://vcs-test.golang.org rerouted to https://127.0.0.1:38441
go test proxy running at GOPROXY=http://127.0.0.1:33193/mod
2022/11/18 19:00:39 http: TLS handshake error from 127.0.0.1:58762: read tcp 127.0.0.1:38441->127.0.0.1:58762: read: connection reset by peer
2022/11/18 19:00:39 http: TLS handshake error from 127.0.0.1:58738: EOF
2022/11/18 19:00:39 http: TLS handshake error from 127.0.0.1:58754: EOF
2022/11/18 19:38:47 httptest.Server blocked in Close after 5 seconds, waiting for connections:
  *net.TCPConn 0xc0001ac2f8 127.0.0.1:37976 in state active
panic: test timed out after 45m0s
running tests:
	TestScript (44m59s)

goroutine 20353 [running]:
panic({0xe705a0, 0xc0007fc040})
	/workdir/go/src/runtime/panic.go:987 +0x3bb fp=0xc00057ff18 sp=0xc00057fe58 pc=0x44aa9b
testing.(*M).startAlarm.func1()
	/workdir/go/src/testing/testing.go:2240 +0x219 fp=0xc00057ffe0 sp=0xc00057ff18 pc=0x5bdb79
runtime.goexit()
	/workdir/go/src/runtime/asm_amd64.s:1598 +0x1 fp=0xc00057ffe8 sp=0xc00057ffe0 pc=0x482e41
created by time.goFunc
	/workdir/go/src/time/sleep.go:176 +0x48

— watchflakes

@bcmills bcmills added this to the Go1.21 milestone Jan 6, 2023
@bcmills bcmills changed the title cmd/go: unrecognized failures cmd/go: TestScript shutdown stall due to blocked hgHandler Jan 6, 2023
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. GoCommand cmd/go labels Jan 6, 2023
@bcmills bcmills self-assigned this Jan 6, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/460997 mentions this issue: cmd/go/internal/vcweb: simplify hgHandler cancellation

@golang golang locked and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bcmills bcmills

Labels
FrozenDueToAge GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Status: Done
Milestone
Go1.21
Development

No branches or pull requests
2 participants
@bcmills @gopherbot