Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go/internal/lockedfile: TestReadWaitsForLock failures #57592

Closed
gopherbot opened this issue Jan 4, 2023 · 3 comments
Closed

cmd/go/internal/lockedfile: TestReadWaitsForLock failures #57592

gopherbot opened this issue Jan 4, 2023 · 3 comments
Assignees
@bcmills
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.21

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "cmd/go/internal/lockedfile" && test == "TestReadWaitsForLock"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestReadWaitsForLock (10.02s)
    lockedfile_test.go:122: WriteString("part 1\n") = <nil>
    lockedfile_test.go:144: WriteString("part 2\n") = <nil>
    lockedfile_test.go:148: Read is unexpectedly still blocked after 10s

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 4, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go/internal/lockedfile" && test == "TestReadWaitsForLock"
2022-11-10 23:11 linux-riscv64-jsing go@1b03568a cmd/go/internal/lockedfile.TestReadWaitsForLock (log) 
--- FAIL: TestReadWaitsForLock (10.02s)
    lockedfile_test.go:122: WriteString("part 1\n") = <nil>
    lockedfile_test.go:144: WriteString("part 2\n") = <nil>
    lockedfile_test.go:148: Read is unexpectedly still blocked after 10s

— watchflakes

@bcmills bcmills self-assigned this Jan 6, 2023
@bcmills
Copy link
Contributor

bcmills commented Jan 6, 2023

I used an arbitrary timeout in this test:
https://cs.opensource.google/go/go/+/master:src/cmd/go/internal/lockedfile/lockedfile_test.go;l=34;drc=c9f7370a096a8b5c2db5996b8b6adbad4e2747d5

I should probably derive it from the test's deadline instead.

@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels Jan 6, 2023
@bcmills bcmills added this to the Go1.21 milestone Jan 6, 2023
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 6, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/461000 mentions this issue: cmd/go/internal/lockedfile: avoid failing tests due to arbitrary timeouts

@golang golang locked and limited conversation to collaborators Jan 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bcmills bcmills

Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Status: Done
Milestone
Go1.21
Development

No branches or pull requests
2 participants
@bcmills @gopherbot