Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/http2: TestTransportReturnsUnusedFlowControlMultipleWrites failures #57578

Closed
gopherbot opened this issue Jan 4, 2023 · 154 comments
Closed
Assignees
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone

Comments

@gopherbot
Copy link

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"

Issue created automatically to collect these failures.

Example (log):

panic: test timed out after 20m0s

sync.runtime_Semacquire(0xc000390b60?)
	/workdir/go/src/runtime/sema.go:62 +0x38
sync.(*WaitGroup).Wait(0xc00126e840)
	/workdir/go/src/sync/waitgroup.go:139 +0x94
golang.org/x/net/http2.(*clientTester).run(0xc0009575e0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x1a8
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0xc000a07e00?, 0x0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0x120
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0x2c8950?)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x30
testing.tRunner(0xc000449860, 0x456580)

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 4, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-01-04 15:52 linux-ppc64le-buildlet net@8e0e7d8d go@c1760296 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 20m0s

sync.runtime_Semacquire(0xc000390b60?)
	/workdir/go/src/runtime/sema.go:62 +0x38
sync.(*WaitGroup).Wait(0xc00126e840)
	/workdir/go/src/sync/waitgroup.go:139 +0x94
golang.org/x/net/http2.(*clientTester).run(0xc0009575e0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x1a8
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0xc000a07e00?, 0x0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0x120
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0x2c8950?)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x30
testing.tRunner(0xc000449860, 0x456580)

watchflakes

@bcmills
Copy link
Contributor

bcmills commented Jan 4, 2023

This looks like a deadlock, and I would be surprised if it did not also affect at least other linux platforms in some cases.

(atten @neild)

@bcmills bcmills added this to the Backlog milestone Jan 4, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-01-04 15:52 linux-ppc64le-buildlet net@8e0e7d8d go@9955a7e9 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 20m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (19m34s)

sync.runtime_Semacquire(0xc000933ba0?)
	/workdir/go/src/runtime/sema.go:62 +0x3c
sync.(*WaitGroup).Wait(0xc001078ee0)
	/workdir/go/src/sync/waitgroup.go:116 +0x88
golang.org/x/net/http2.(*clientTester).run(0xc000904d20)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x1a8
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0xc000a58d80?, 0x0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0x120
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0xc0010eb710?)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x30
testing.tRunner(0xc0008181a0, 0x46b790)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-01-04 15:52 linux-amd64-longtest-race net@8e0e7d8d go@4e7c8384 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 50m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (48m38s)

sync.runtime_Semacquire(0xc000492b48?)
	/workdir/go/src/runtime/sema.go:62 +0x27
sync.(*WaitGroup).Wait(0xc000492b40)
	/workdir/go/src/sync/waitgroup.go:116 +0xa5
golang.org/x/net/http2.(*clientTester).run(0xc000298690)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x32f
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0x0?, 0x0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0x19b
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0x0?)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x31
testing.tRunner(0xc00099e340, 0xac71d8)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-01-05 16:42 netbsd-arm64-bsiegert net@f8411da7 go@d50ea217 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 1h40m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (1h39m20s)

sync.runtime_Semacquire(0x400050ed00?)
	/scratch/gobuilder/buildlet/go/src/runtime/sema.go:62 +0x2c
sync.(*WaitGroup).Wait(0x400122b100)
	/scratch/gobuilder/buildlet/go/src/sync/waitgroup.go:116 +0x74
golang.org/x/net/http2.(*clientTester).run(0x400085a870)
	/scratch/gobuilder/buildlet/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x180
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0x4001425f58?, 0x0)
	/scratch/gobuilder/buildlet/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0xf8
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0x40005fdf40?)
	/scratch/gobuilder/buildlet/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x20
testing.tRunner(0x40001b1ba0, 0x42bde8)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-01-05 16:42 linux-amd64-nocgo net@f8411da7 go@119f679a x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 10m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (9m46s)

sync.runtime_Semacquire(0xc0016feb28?)
	/workdir/go/src/runtime/sema.go:62 +0x27
sync.(*WaitGroup).Wait(0x18?)
	/workdir/go/src/sync/waitgroup.go:116 +0x4b
golang.org/x/net/http2.(*clientTester).run(0xc000f04fa0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x187
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0xc001404f60?, 0x0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0xf1
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0xb87128?)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x1b
testing.tRunner(0xc001196b60, 0x888898)

watchflakes

@bcmills
Copy link
Contributor

bcmills commented Jan 6, 2023

I would be surprised if it did not also affect at least other linux platforms in some cases.

Indeed, there it is — linux/amd64 and netbsd/arm64 have no elements in common. 😅

@bcmills
Copy link
Contributor

bcmills commented Jan 6, 2023

Given the number of very recent failures reported, I suspect that this was introduced in CL 448155.

@neild, @heschi, @bradfitz: given that this landed during the freeze and http2 is bundled into the main repo, does this need attention before the Go 1.20 release?

@bcmills bcmills modified the milestones: Backlog, Go1.20, Go1.21 Jan 6, 2023
@bcmills
Copy link
Contributor

bcmills commented Jan 6, 2023

Looks like this hasn't been pulled into the main repo yet, so this doesn't need to be a release blocker for 1.20 unless we're planning to refresh the x dependencies one more time before the final release. (@golang/release can confirm whether that is the case?)

But it will presumably need to be resolved before we can update x/net for the 1.21 cycle, so marking as release-blocker for 1.21.

@dmitshur
Copy link
Contributor

dmitshur commented Jan 6, 2023

unless we're planning to refresh the x dependencies one more time before the final release. (@golang/release can confirm whether that is the case?)

We create internal vendor branches for x repos at the time of cutting RC 1 (see #11811 (comment)), and after that point we've generally been adding to that branch only the CLs that are necessary to fix release-blocking issues for the given release. So the 1.21 milestone seems okay to start out with here.

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-01-05 16:42 android-amd64-emu net@f8411da7 go@841c3eb1 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 10m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (9m44s)

sync.runtime_Semacquire(0xc0011ae090?)
	/workdir/go/src/runtime/sema.go:62 +0x27
sync.(*WaitGroup).Wait(0x18?)
	/workdir/go/src/sync/waitgroup.go:116 +0x4b
golang.org/x/net/http2.(*clientTester).run(0xc0010dc910)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x187
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0xc0004c3f60?, 0x0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0xf1
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0xc00121ced0?)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x1b
testing.tRunner(0xc000825380, 0x7f6fba1df038)
2023-01-05 16:42 android-amd64-emu net@f8411da7 go@f721fa3b x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 10m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (9m42s)

sync.runtime_Semacquire(0xc001249740?)
	/workdir/go/src/runtime/sema.go:62 +0x27
sync.(*WaitGroup).Wait(0x18?)
	/workdir/go/src/sync/waitgroup.go:116 +0x4b
golang.org/x/net/http2.(*clientTester).run(0xc0008d9ef0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x187
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0xc000ba3f60?, 0x0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0xf1
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0x0?)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x1b
testing.tRunner(0xc0005016c0, 0x78fb6e065038)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-01-05 16:42 linux-ppc64le-buildlet net@f8411da7 go@841c3eb1 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 20m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (19m36s)

sync.runtime_Semacquire(0xc002c01860?)
	/workdir/go/src/runtime/sema.go:62 +0x3c
sync.(*WaitGroup).Wait(0xc000ed1aa0)
	/workdir/go/src/sync/waitgroup.go:116 +0x88
golang.org/x/net/http2.(*clientTester).run(0xc000545360)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x1a8
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0xc00053f200?, 0x0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0x120
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0x76a120?)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x30
testing.tRunner(0xc0000b0ea0, 0x46b790)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-01-05 16:42 netbsd-amd64-9_3 net@f8411da7 go@8232a09e x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 10m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (9m46s)

sync.runtime_Semacquire(0xc001941b00?)
	/tmp/workdir/go/src/runtime/sema.go:62 +0x27
sync.(*WaitGroup).Wait(0x18?)
	/tmp/workdir/go/src/sync/waitgroup.go:116 +0x4b
golang.org/x/net/http2.(*clientTester).run(0xc0006fd130)
	/tmp/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x187
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0xc000259f60?, 0x0)
	/tmp/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0xf1
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0xc000b30000?)
	/tmp/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x1b
testing.tRunner(0xc000b301a0, 0x8890d0)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-01-05 16:42 android-amd64-emu net@f8411da7 go@0bbd67e5 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 10m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (9m41s)

sync.runtime_Semacquire(0xc0010ed6b0?)
	/workdir/go/src/runtime/sema.go:62 +0x27
sync.(*WaitGroup).Wait(0x18?)
	/workdir/go/src/sync/waitgroup.go:116 +0x4b
golang.org/x/net/http2.(*clientTester).run(0xc00079fb80)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x187
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0xc000643f60?, 0x0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0xf1
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0xc000fb4600?)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x1b
testing.tRunner(0xc0019eaea0, 0x710084987038)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-01-05 16:42 linux-386-bullseye net@f8411da7 go@0202ad0b x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 10m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (9m14s)

sync.runtime_Semacquire(0x9fed9a8)
	/workdir/go/src/runtime/sema.go:62 +0x3b
sync.(*WaitGroup).Wait(0x9fed9a0)
	/workdir/go/src/sync/waitgroup.go:116 +0x65
golang.org/x/net/http2.(*clientTester).run(0x9f802a0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x190
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0x9b850e0, 0x0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0xef
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0x9b850e0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x26
testing.tRunner(0x9b850e0, 0x8493328)
2023-01-05 16:42 netbsd-386-9_3 net@f8411da7 go@0202ad0b x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 10m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (9m25s)

sync.runtime_Semacquire(0x97735b8)
	/tmp/workdir/go/src/runtime/sema.go:62 +0x35
sync.(*WaitGroup).Wait(0x97735b0)
	/tmp/workdir/go/src/sync/waitgroup.go:116 +0x5f
golang.org/x/net/http2.(*clientTester).run(0x977ccc0)
	/tmp/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x18a
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0x97183c0, 0x0)
	/tmp/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0xe9
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0x97183c0)
	/tmp/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x20
testing.tRunner(0x97183c0, 0x8483ab4)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-01-05 16:42 netbsd-amd64-9_3 net@f8411da7 go@8409251e x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 10m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (9m46s)

sync.runtime_Semacquire(0xc001836a20?)
	/tmp/workdir/go/src/runtime/sema.go:62 +0x27
sync.(*WaitGroup).Wait(0x18?)
	/tmp/workdir/go/src/sync/waitgroup.go:116 +0x4b
golang.org/x/net/http2.(*clientTester).run(0xc000982410)
	/tmp/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x187
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0xc0002d2f60?, 0x0)
	/tmp/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0xf1
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0xc0013ad6b0?)
	/tmp/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x1b
testing.tRunner(0xc00183c1a0, 0x8890d0)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-01-05 16:42 linux-loong64-3a5000 net@f8411da7 go@c0799f70 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 10m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (9m34s)

sync.runtime_Semacquire(0xc0011be9d8)
	/tmp/workdir-host-linux-loong64-3a5000/go/src/runtime/sema.go:62 +0x4c
sync.(*WaitGroup).Wait(0xc0011be9d0)
	/tmp/workdir-host-linux-loong64-3a5000/go/src/sync/waitgroup.go:116 +0x74
golang.org/x/net/http2.(*clientTester).run(0xc0009a1040)
	/tmp/workdir-host-linux-loong64-3a5000/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x1b8
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0xc0002d8d00, 0x0)
	/tmp/workdir-host-linux-loong64-3a5000/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0x124
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0xc0002d8d00)
	/tmp/workdir-host-linux-loong64-3a5000/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x34
testing.tRunner(0xc0002d8d00, 0x120471bd8)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-01-05 16:42 linux-ppc64le-buildlet net@f8411da7 go@d45df066 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 20m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (19m30s)

sync.runtime_Semacquire(0xc0000a4b60?)
	/workdir/go/src/runtime/sema.go:62 +0x3c
sync.(*WaitGroup).Wait(0xc00104d540)
	/workdir/go/src/sync/waitgroup.go:116 +0x88
golang.org/x/net/http2.(*clientTester).run(0xc000fc27d0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x1a8
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0x0?, 0x0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0x120
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0x2de130?)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x30
testing.tRunner(0xc00124a1a0, 0x46b790)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-01-05 16:42 android-386-emu net@f8411da7 go@73e1affe x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
SIGQUIT: quit
PC=0xeeaa5ea7 m=0 sigcode=0

eax    0xfffffffc
ebx    0x3
ecx    0xffc0dbcc
edx    0x80
edi    0xffc0e1cc
esi    0x22411
ebp    0x0
...
	/workdir/go/src/runtime/sema.go:62 +0x37 fp=0xbe22bef8 sp=0xbe22bee4 pc=0xeeaa1df7
sync.(*WaitGroup).Wait(0xbeeb5130)
	/workdir/go/src/sync/waitgroup.go:139 +0x88 fp=0xbe22bf1c sp=0xbe22bef8 pc=0xeeaab9e8
golang.org/x/net/http2.(*clientTester).run(0xbeea6d20)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x1ce fp=0xbe22bf44 sp=0xbe22bf1c pc=0xeedbec0e
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0xbe55b1d0, 0x0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0x10a fp=0xbe22bf54 sp=0xbe22bf44 pc=0xeedd23aa
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0xbe55b1d0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x27 fp=0xbe22bf60 sp=0xbe22bf54 pc=0xeedd3167
testing.tRunner(0xbe55b1d0, 0xeef3518c)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-01-05 16:42 netbsd-amd64-9_3 net@f8411da7 go@8d71ae8c x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 10m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (9m45s)

sync.runtime_Semacquire(0xc0016dd878?)
	/tmp/workdir/go/src/runtime/sema.go:62 +0x27
sync.(*WaitGroup).Wait(0x18?)
	/tmp/workdir/go/src/sync/waitgroup.go:116 +0x4b
golang.org/x/net/http2.(*clientTester).run(0xc0001ebbd0)
	/tmp/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x187
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0xc00024af60?, 0x0)
	/tmp/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0xf1
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0xb87d68?)
	/tmp/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x1b
testing.tRunner(0xc0001fcb60, 0x8890d0)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-01-05 16:42 android-386-emu net@f8411da7 go@8d71ae8c x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 10m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (9m20s)

sync.runtime_Semacquire(0xc1d984b8)
	/workdir/go/src/runtime/sema.go:62 +0x3c
sync.(*WaitGroup).Wait(0xc1d984b0)
	/workdir/go/src/sync/waitgroup.go:116 +0x66
golang.org/x/net/http2.(*clientTester).run(0xc17f8750)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x1ce
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0xc16d85a0, 0x0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0x10a
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0xc16d85a0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x27
testing.tRunner(0xc16d85a0, 0xea22223c)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-01-05 16:42 linux-amd64-sid net@f8411da7 go@e590afcf x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 10m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (9m46s)

sync.runtime_Semacquire(0xc0016cdf50?)
	/workdir/go/src/runtime/sema.go:62 +0x27
sync.(*WaitGroup).Wait(0x18?)
	/workdir/go/src/sync/waitgroup.go:116 +0x4b
golang.org/x/net/http2.(*clientTester).run(0xc000d07ae0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x187
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0xc001706f60?, 0x0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0xf1
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0xb998a8?)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x1b
testing.tRunner(0xc00194e1a0, 0x893a58)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-02-28 08:42 linux-amd64-longtest-race net@1d46ed8b go@79d4e894 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 50m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (48m55s)

sync.runtime_Semacquire(0xc000f2a998?)
	/workdir/go/src/runtime/sema.go:62 +0x25
sync.(*WaitGroup).Wait(0xc000f2a990)
	/workdir/go/src/sync/waitgroup.go:116 +0xa5
golang.org/x/net/http2.(*clientTester).run(0xc000cd67d0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x316
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0x0?, 0x0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0x1a8
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0x0?)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x29
testing.tRunner(0xc000b02680, 0xab0ae0)
2023-02-28 08:42 linux-ppc64-sid-buildlet net@1d46ed8b go@79d4e894 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 20m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (19m29s)

sync.runtime_Semacquire(0xc002547a00?)
	/workdir/go/src/runtime/sema.go:62 +0x3c
sync.(*WaitGroup).Wait(0xc000f1d520)
	/workdir/go/src/sync/waitgroup.go:116 +0x88
golang.org/x/net/http2.(*clientTester).run(0xc000617900)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x194
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0x4d5aa8?, 0x0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0x118
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0x2eac60?)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x30
testing.tRunner(0xc000291520, 0x469630)
2023-02-28 08:42 linux-ppc64-sid-buildlet net@1d46ed8b go@6f4d986a x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 20m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (19m23s)

sync.runtime_Semacquire(0xc000082820?)
	/workdir/go/src/runtime/sema.go:62 +0x3c
sync.(*WaitGroup).Wait(0xc001120c70)
	/workdir/go/src/sync/waitgroup.go:116 +0x88
golang.org/x/net/http2.(*clientTester).run(0xc001170000)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x194
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0x4d5aa8?, 0x0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0x118
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0x2eac60?)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x30
testing.tRunner(0xc000998d00, 0x469630)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-02-28 08:42 linux-386-longtest net@1d46ed8b go@0487ba08 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 50m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (49m31s)

sync.runtime_Semacquire(0xa4de018)
	/workdir/go/src/runtime/sema.go:62 +0x3b
sync.(*WaitGroup).Wait(0xa4de010)
	/workdir/go/src/sync/waitgroup.go:116 +0x65
golang.org/x/net/http2.(*clientTester).run(0x9938090)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x16b
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0x9946000, 0x0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0xe3
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0x9946000)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x26
testing.tRunner(0x9946000, 0x84a6e28)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-02-28 08:42 netbsd-arm64-bsiegert net@1d46ed8b go@6f4d986a x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 1h40m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (1h39m20s)

sync.runtime_Semacquire(0x40008c76c0?)
	/scratch/gobuilder/buildlet/go/src/runtime/sema.go:62 +0x2c
sync.(*WaitGroup).Wait(0x4001728f10)
	/scratch/gobuilder/buildlet/go/src/sync/waitgroup.go:116 +0x74
golang.org/x/net/http2.(*clientTester).run(0x40015f0230)
	/scratch/gobuilder/buildlet/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x168
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0x4000fd3f58?, 0x0)
	/scratch/gobuilder/buildlet/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0xf0
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0x0?)
	/scratch/gobuilder/buildlet/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x20
testing.tRunner(0x4000327d40, 0x4402e0)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-02-28 08:42 linux-amd64-boringcrypto net@1d46ed8b go@0d288f90 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 10m0s

sync.runtime_Semacquire(0xc000fe18a8?)
	/workdir/go/src/runtime/sema.go:62 +0x25
sync.(*WaitGroup).Wait(0xc000068c00?)
	/workdir/go/src/sync/waitgroup.go:139 +0x52
golang.org/x/net/http2.(*clientTester).run(0xc000304230)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x187
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0xc000808f60?, 0x0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0xf1
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0x0?)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x1b
testing.tRunner(0xc002082340, 0x9f8f88)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-02-28 08:42 linux-amd64-race net@1d46ed8b go@5e74bc1a x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 10m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (8m44s)

sync.runtime_Semacquire(0xc000504328?)
	/workdir/go/src/runtime/sema.go:62 +0x25
sync.(*WaitGroup).Wait(0xc000504320)
	/workdir/go/src/sync/waitgroup.go:116 +0xa5
golang.org/x/net/http2.(*clientTester).run(0xc000258370)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x316
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0x0?, 0x0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0x1a8
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0x0?)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x29
testing.tRunner(0xc0009f7520, 0xab0ae0)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-03-03 16:07 linux-ppc64-sid-buildlet net@8c4ef2f8 go@cd6d225b x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 20m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (19m31s)

sync.runtime_Semacquire(0xc000469520?)
	/workdir/go/src/runtime/sema.go:62 +0x3c
sync.(*WaitGroup).Wait(0xc001298160)
	/workdir/go/src/sync/waitgroup.go:116 +0x88
golang.org/x/net/http2.(*clientTester).run(0xc0005d0780)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x194
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0x4d5aa8?, 0x0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0x118
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0x2eacb0?)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x30
testing.tRunner(0xc0001dad00, 0x469630)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-03-03 16:07 linux-amd64-longtest-race net@8c4ef2f8 go@ce2a6099 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 50m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (48m56s)

sync.runtime_Semacquire(0xc002144538?)
	/workdir/go/src/runtime/sema.go:62 +0x25
sync.(*WaitGroup).Wait(0xc002144530)
	/workdir/go/src/sync/waitgroup.go:116 +0xa5
golang.org/x/net/http2.(*clientTester).run(0xc000f12370)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x316
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0x0?, 0x0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0x1a8
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0x0?)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x29
testing.tRunner(0xc000c02340, 0xab0c60)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-03-03 16:07 linux-amd64-goamd64v3 net@8c4ef2f8 go@b94dc384 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 10m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (9m48s)

sync.runtime_Semacquire(0xc0021098a8?)
	/workdir/go/src/runtime/sema.go:62 +0x25
sync.(*WaitGroup).Wait(0x18?)
	/workdir/go/src/sync/waitgroup.go:116 +0x48
golang.org/x/net/http2.(*clientTester).run(0xc002178640)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x171
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0xc000f74f60?, 0x0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0xde
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0x0?)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x15
testing.tRunner(0xc000902d00, 0x871008)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-03-05 02:51 android-amd64-emu net@dfa2b5df go@74502e9b x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 10m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (9m41s)

sync.runtime_Semacquire(0xc0011cedb0?)
	/workdir/go/src/runtime/sema.go:62 +0x25
sync.(*WaitGroup).Wait(0x18?)
	/workdir/go/src/sync/waitgroup.go:116 +0x48
golang.org/x/net/http2.(*clientTester).run(0xc0008cbe50)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x171
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0xc000a8cf60?, 0x0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0xde
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0x0?)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x15
testing.tRunner(0xc0009169c0, 0x7afbd54f81f8)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-03-05 02:51 android-386-emu net@dfa2b5df go@34d6aaae x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 10m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (9m17s)

sync.runtime_Semacquire(0xc2816a38)
	/workdir/go/src/runtime/sema.go:62 +0x3c
sync.(*WaitGroup).Wait(0xc2816a30)
	/workdir/go/src/sync/waitgroup.go:116 +0x66
golang.org/x/net/http2.(*clientTester).run(0xc21d3b60)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x1a9
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0xc28223c0, 0x0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0xfe
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0xc28223c0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x27
testing.tRunner(0xc28223c0, 0xeb12d134)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-03-05 02:51 linux-ppc64-sid-buildlet net@dfa2b5df go@74502e9b x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 20m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (19m31s)

sync.runtime_Semacquire(0xc0002c1040?)
	/workdir/go/src/runtime/sema.go:62 +0x3c
sync.(*WaitGroup).Wait(0xc0011a54d0)
	/workdir/go/src/sync/waitgroup.go:116 +0x88
golang.org/x/net/http2.(*clientTester).run(0xc001302780)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x194
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0x4d5330?, 0x0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0x118
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0xc0008c5900?)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x30
testing.tRunner(0xc000301380, 0x469788)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-03-05 02:51 linux-amd64-race net@dfa2b5df go@8f92ae1c x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 10m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (8m43s)

sync.runtime_Semacquire(0xc00002c4a8?)
	/workdir/go/src/runtime/sema.go:62 +0x25
sync.(*WaitGroup).Wait(0xc00002c4a0)
	/workdir/go/src/sync/waitgroup.go:116 +0xa5
golang.org/x/net/http2.(*clientTester).run(0xc0008d0140)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x316
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0x0?, 0x0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0x1a8
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0x0?)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x29
testing.tRunner(0xc000132000, 0xab0c60)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-03-05 02:51 linux-ppc64le-buildlet net@dfa2b5df go@c6cdfdab x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 20m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (19m31s)

sync.runtime_Semacquire(0xc00045cb60?)
	/workdir/go/src/runtime/sema.go:62 +0x3c
sync.(*WaitGroup).Wait(0xc0014803f0)
	/workdir/go/src/sync/waitgroup.go:116 +0x88
golang.org/x/net/http2.(*clientTester).run(0xc000a04aa0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x194
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0x4db490?, 0x0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0x118
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0xc000a886e0?)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x30
testing.tRunner(0xc000558820, 0x470090)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-03-05 02:51 linux-386-clang net@dfa2b5df go@84609d87 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 10m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (9m36s)

sync.runtime_Semacquire(0xaba4298)
	/workdir/go/src/runtime/sema.go:62 +0x3b
sync.(*WaitGroup).Wait(0xaba4290)
	/workdir/go/src/sync/waitgroup.go:116 +0x65
golang.org/x/net/http2.(*clientTester).run(0xa423350)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x16b
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0xa37e960, 0x0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0xe3
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0xa37e960)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x26
testing.tRunner(0xa37e960, 0x84a6f88)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-03-05 02:51 android-386-emu net@dfa2b5df go@7bd22aaf x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 10m0s

sync.runtime_Semacquire(0xc19e2918)
	/workdir/go/src/runtime/sema.go:62 +0x37
sync.(*WaitGroup).Wait(0xc19e2910)
	/workdir/go/src/sync/waitgroup.go:139 +0x88
golang.org/x/net/http2.(*clientTester).run(0xc198be00)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x1ce
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0xc0d5bd10, 0x0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0x10a
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0xc0d5bd10)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x27
testing.tRunner(0xc0d5bd10, 0xf1a267d4)
2023-03-05 02:51 netbsd-386-9_3 net@dfa2b5df go@7bd22aaf x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 10m0s

sync.runtime_Semacquire(0x9a21d58)
	/tmp/workdir/go/src/runtime/sema.go:62 +0x30
sync.(*WaitGroup).Wait(0x9a21d50)
	/tmp/workdir/go/src/sync/waitgroup.go:139 +0x81
golang.org/x/net/http2.(*clientTester).run(0x9a38180)
	/tmp/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x18a
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0x8b0cc30, 0x0)
	/tmp/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0xe9
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0x8b0cc30)
	/tmp/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x20
testing.tRunner(0x8b0cc30, 0x8481cb0)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-03-07 22:09 linux-amd64-buster net@08dda575 go@7bd22aaf x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 10m0s

sync.runtime_Semacquire(0xc0014611b8?)
	/workdir/go/src/runtime/sema.go:62 +0x25
sync.(*WaitGroup).Wait(0xc000100400?)
	/workdir/go/src/sync/waitgroup.go:139 +0x52
golang.org/x/net/http2.(*clientTester).run(0xc00139e500)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x187
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0xc000411f60?, 0x0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0xf1
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0x0?)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x1b
testing.tRunner(0xc0008844e0, 0x886048)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-03-05 02:51 linux-mips64-rtrk net@dfa2b5df go@84609d87 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 40m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (37m35s)

sync.runtime_Semacquire(0xc000eff388)
	/tmp/gobuilder-mips64/go/src/runtime/sema.go:62 +0x58
sync.(*WaitGroup).Wait(0xc000eff380)
	/tmp/gobuilder-mips64/go/src/sync/waitgroup.go:116 +0x98
golang.org/x/net/http2.(*clientTester).run(0xc0010b6000)
	/tmp/gobuilder-mips64/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x228
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0xc000528820, 0x0)
	/tmp/gobuilder-mips64/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0x178
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0xc000528820)
	/tmp/gobuilder-mips64/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x44
testing.tRunner(0xc000528820, 0x1205533a8)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-03-07 22:09 linux-ppc64-sid-buildlet net@08dda575 go@457fd1d5 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 20m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (19m25s)

sync.runtime_Semacquire(0xc000a36820?)
	/workdir/go/src/runtime/sema.go:62 +0x3c
sync.(*WaitGroup).Wait(0xc00123a170)
	/workdir/go/src/sync/waitgroup.go:116 +0x88
golang.org/x/net/http2.(*clientTester).run(0xc0012400a0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x194
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0xc0001f69c0?, 0x0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0x118
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0x2eae20?)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x30
testing.tRunner(0xc0001f6b60, 0x4697f0)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-02-14 17:04 darwin-amd64-11_0 net@8e2b117a go@4a1829b6 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 10m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (9m26s)

sync.runtime_Semacquire(0xc001325ef0?)
	/tmp/buildlet/go/src/runtime/sema.go:62 +0x25
sync.(*WaitGroup).Wait(0x18?)
	/tmp/buildlet/go/src/sync/waitgroup.go:116 +0x48
golang.org/x/net/http2.(*clientTester).run(0xc000a1fcc0)
	/tmp/buildlet/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x185
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0xc0011cdf60?, 0x0)
	/tmp/buildlet/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0xd1
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0xc000981b00?)
	/tmp/buildlet/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x15
testing.tRunner(0xc0003f8d00, 0x1471138)
2023-02-14 17:04 linux-mips64-rtrk net@8e2b117a go@f98dd299 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 40m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (37m32s)

sync.runtime_Semacquire(0xc001062ff8)
	/tmp/gobuilder-mips64/go/src/runtime/sema.go:62 +0x58
sync.(*WaitGroup).Wait(0xc001062ff0)
	/tmp/gobuilder-mips64/go/src/sync/waitgroup.go:116 +0x98
golang.org/x/net/http2.(*clientTester).run(0xc0007e91d0)
	/tmp/gobuilder-mips64/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x258
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0xc00038ba00, 0x0)
	/tmp/gobuilder-mips64/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0x190
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0xc00038ba00)
	/tmp/gobuilder-mips64/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x44
testing.tRunner(0xc00038ba00, 0x12054ea70)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-03-07 22:09 linux-ppc64le-buildlet net@08dda575 go@20c96a7d x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 20m0s

sync.runtime_Semacquire(0xc001401a00?)
	/workdir/go/src/runtime/sema.go:62 +0x38
sync.(*WaitGroup).Wait(0xc00116c520)
	/workdir/go/src/sync/waitgroup.go:139 +0x94
golang.org/x/net/http2.(*clientTester).run(0xc000940730)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x1a8
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0x0?, 0x0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0x120
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0x2d2730?)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x30
testing.tRunner(0xc00069e4e0, 0x456ff0)

watchflakes

@gopherbot
Copy link
Author

Change https://go.dev/cl/475135 mentions this issue: http2: properly discard data received after request/response body is closed

@neild
Copy link
Contributor

neild commented Mar 9, 2023

This is a real bug.

The problem is that when the user closes a Response.Body or an inbound Request.Body, indicating that they aren't going to read further data from it, writes to the body silently succeed. Since the Transport or Server don't see an error from the write, they assume that flow control credit for the received data will be returned when it is read.

There is, therefore, a race condition between closing a request/response body and notifying the peer that it can stop sending data.

For the Transport case, this manifests as a flaky test. The Server case wasn't covered by any tests.

See https://go.dev/cl/475135 for more details and fix.

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-03-07 22:09 linux-amd64-longtest net@08dda575 go@7042ea62 x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 50m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (49m41s)

sync.runtime_Semacquire(0xc000dec390?)
	/workdir/go/src/runtime/sema.go:62 +0x25
sync.(*WaitGroup).Wait(0x18?)
	/workdir/go/src/sync/waitgroup.go:116 +0x48
golang.org/x/net/http2.(*clientTester).run(0xc000efa370)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x171
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0xc000baef60?, 0x0)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0xde
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0x0?)
	/workdir/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x15
testing.tRunner(0xc000ce8340, 0x871ee0)

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/net/http2" && test == "TestTransportReturnsUnusedFlowControlMultipleWrites"
2023-03-07 22:09 darwin-amd64-12_0 net@08dda575 go@4460291e x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites (log)
panic: test timed out after 10m0s
running tests:
	TestTransportReturnsUnusedFlowControlMultipleWrites (9m29s)

sync.runtime_Semacquire(0xc001429248?)
	/tmp/buildlet/go/src/runtime/sema.go:62 +0x25
sync.(*WaitGroup).Wait(0x18?)
	/tmp/buildlet/go/src/sync/waitgroup.go:116 +0x48
golang.org/x/net/http2.(*clientTester).run(0xc000b4b360)
	/tmp/buildlet/gopath/src/golang.org/x/net/http2/transport_test.go:912 +0x171
golang.org/x/net/http2.testTransportReturnsUnusedFlowControl(0xc0001eef60?, 0x0)
	/tmp/buildlet/gopath/src/golang.org/x/net/http2/transport_test.go:3070 +0xde
golang.org/x/net/http2.TestTransportReturnsUnusedFlowControlMultipleWrites(0xc000393b80?)
	/tmp/buildlet/gopath/src/golang.org/x/net/http2/transport_test.go:3080 +0x15
testing.tRunner(0xc0009c84e0, 0x1470c58)

watchflakes

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Mar 17, 2023
@golang golang locked and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
Status: Done
Development

No branches or pull requests

6 participants