Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: performance regression in goawk #57563

Closed
mdempsky opened this issue Jan 3, 2023 · 1 comment
Closed

cmd/compile: performance regression in goawk #57563

mdempsky opened this issue Jan 3, 2023 · 1 comment
Assignees
@mdempsky
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.

Comments

@mdempsky
Copy link
Member

mdempsky commented Jan 3, 2023

As reported at https://groups.google.com/g/golang-dev/c/8blU7CnuhZ4/m/d21xuN8hAQAJ, goawk sees a performance slowdown with 1.20 previews.

@randall77 identified that the likely cause is isBigFunc not liking the extra IR generated for a, b = f() style multi-value assignments.

We have logic in the inliner's heuristics already to account for this. I think we just need to repeat the logic in isBigFunc.
@mdempsky mdempsky added the NeedsFix The path to resolution is known, but the work has not been done. label Jan 3, 2023
@mdempsky mdempsky self-assigned this Jan 3, 2023
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jan 3, 2023
@gopherbot
Copy link

Change https://go.dev/cl/460395 mentions this issue: cmd/compile/internal/inline: adjust isBigFunc to recognize unified IR codegen

@golang golang locked and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mdempsky mdempsky

Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdempsky @gopherbot