Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: TestRenamePackage_InternalPackage failing on linux-amd64-wsl builder #57555

Closed
findleyr opened this issue Jan 3, 2023 · 2 comments
Closed

x/tools/gopls: TestRenamePackage_InternalPackage failing on linux-amd64-wsl builder #57555

findleyr opened this issue Jan 3, 2023 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.12.0

Comments

@findleyr
Copy link
Member

findleyr commented Jan 3, 2023

It looks like the linux-amd64-wsl builder is generally unhappy. It seems to have encountered "hanging go commands" very frequently, but that is a separate issue (#54461).

Recent failures appear deterministic, failing with "permission denied", starting with https://go.dev/cl/459416. This may be because the go command is still holding onto a file, but the failure mode does seem related to that change.
https://build.golang.org/log/5053369eca96766a09d70f36ed4ac8926fc182a1

rename_test.go:940: renaming sandbox file: rename /tmp/workdir-host-linux-amd64-wsl/tmp/gopls-regtest-4043663239/TestRenamePackage_InternalPackage/default/work/lib /tmp/workdir-host-linux-amd64-wsl/tmp/gopls-regtest-4043663239/TestRenamePackage_InternalPackage/default/work/lib1: permission denied

CC @dle8
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jan 3, 2023
@gopherbot gopherbot added this to the Unreleased milestone Jan 3, 2023
@findleyr findleyr added this to the gopls/v0.12.0 milestone Jan 3, 2023
@heschi
Copy link
Contributor

heschi commented Jan 3, 2023

The WSL builder has been sick, see https://go.dev/issue/57517.

@findleyr
Copy link
Member Author

findleyr commented May 3, 2023

Closing as dupe of #57517

@findleyr findleyr closed this as completed May 3, 2023
@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale May 3, 2023
@golang golang locked and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.12.0
Development

No branches or pull requests
3 participants
@gopherbot @heschi @findleyr