Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: LookupAddr does not set IsNotFound with cgo resolver #57548

Closed
rudis opened this issue Jan 2, 2023 · 5 comments
Closed

net: LookupAddr does not set IsNotFound with cgo resolver #57548

rudis opened this issue Jan 2, 2023 · 5 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.20

Comments

@rudis
Copy link

rudis commented Jan 2, 2023

What version of Go are you using (go version)?

$ go version
go version go1.19.4 linux/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="$HOME/.cache/go-build"
GOENV="$HOME/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="$HOME/dev/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/opt/go/go1.19.4"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/opt/go/go1.19.4/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.19.4"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=/run/user/$UID/go-build1957738364=/tmp/go-build -gno-record-gcc-switches"

What did you do?

$ cat > x.go <<EOF
package main
import (
        "fmt"
        "net"
)
func main() {
        _, err := net.LookupAddr("1.2.3.4")
        fmt.Printf("%v\n", err.(*net.DNSError).IsNotFound)
}
EOF

$ GODEBUG=netdns=go go run x.go
true

$ GODEBUG=netdns=cgo go run x.go
false

What did you expect to see?

Both go and cgo resolver correctly report IsNotFound.

What did you see instead?

Only go resolver does so.

There's already a pull request for this but it wasn't merged: #45959
@rudis
Copy link
Author

rudis commented Jan 2, 2023

I think this CL is unrelated because it changes cgoLookupIPCNAME and not cgoLookupAddrPTR which is used by LookupAddr.

@mateusz834
Copy link
Member

@rudis you are right, my mistake, deleted that comment. I will make a new CL for this.

@mateusz834 mateusz834 mentioned this issue Jan 2, 2023
Closed
@gopherbot
Copy link

Change https://go.dev/cl/460255 mentions this issue: net: report IsNotFound when getnameinfo returns EAI_NONAME

@heschi
Copy link
Contributor

heschi commented Jan 3, 2023

cc @neild @ianlancetaylor

@heschi heschi added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 3, 2023
@heschi heschi added this to the Go1.20 milestone Jan 3, 2023
@rudis
Copy link
Author

rudis commented Jan 3, 2023

@rudis you are right, my mistake, deleted that comment. I will make a new CL for this.

Thanks for the quick response. CL looks good to me.

johanbrandhorst pushed a commit to Pryz/go that referenced this issue Feb 12, 2023
@mateusz834 @johanbrandhorst
net: report IsNotFound when getnameinfo returns EAI_NONAME
9034655 
Fixes golang#57548

Change-Id: I4092624b1e906fbcd520f43aa4bc71c144dea3b6
GitHub-Last-Rev: ab04835
GitHub-Pull-Request: golang#57549
Reviewed-on: https://go-review.googlesource.com/c/go/+/460255
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Damien Neil <dneil@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
@mateusz834 mateusz834 mentioned this issue Nov 7, 2023
Closed
@golang golang locked and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Go1.20
Development

Successfully merging a pull request may close this issue.

net: report IsNotFound when getnameinfo returns EAI_NONAME mateusz834/go
4 participants
@rudis @gopherbot @mateusz834 @heschi