Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/devapp/owners: document responsibilities of primary and secondary code owners #57532

Open
hickford opened this issue Dec 31, 2022 · 3 comments
Open

x/build/devapp/owners: document responsibilities of primary and secondary code owners #57532

hickford opened this issue Dec 31, 2022 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) Documentation NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@hickford
Copy link

hickford commented Dec 31, 2022 •
edited

Go Code Owners page https://dev.golang.org/owners lists primary and secondary code owners by project. The page should explain what this information means -- what are the responsibilities of code owners? https://go.dev/doc/contribute doesn't mention code owners at all.

It should also explain the difference between primary and secondary owners. It looks like Gerrit https://go-review.googlesource.com/ automatically adds primaries as reviewers. Are there any other differences?
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Dec 31, 2022
@gopherbot gopherbot added this to the Unreleased milestone Dec 31, 2022
@hickford hickford mentioned this issue Dec 31, 2022
Open
@dmitshur
Copy link
Contributor

CC @golang/release.

@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 1, 2023
@hickford hickford changed the title x/build/devapp/owners: document role of primaries and secondaries x/build/devapp/owners: document responsibilities of primary and secondary code owners Jul 18, 2023
This was referenced Jul 18, 2023
Open
Closed
@hickford
Copy link
Author

hickford commented Jul 18, 2023 •
edited

@dmitshur @golang/release @golang/proposal-review Is anyone able to explain the responsibilities of Go code owners and the difference between primaries and secondaries? https://dev.golang.org/owners doesn't explain and https://go.dev/doc/contribute doesn't even mention code owners.

@dmitshur
Copy link
Contributor

I'll note that there are some mentions of owners in https://go.dev/wiki/GerritAccess:

Typically, you should only Code-Review+2 code in directories or packages that you "own"; the exception is trivial and obviously correct changes.

You should only submit changes with a Code-Review+2 from the owner of that area (maybe you!).

And some mentions of "port maintainers", which is similar to code owners but for ports, in https://go.dev/wiki/PortingPolicy.

The distinction between primary and secondary is not at all well defined at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) Documentation NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@hickford @dmitshur @gopherbot