Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/dashboard: add js-wasm-node18 builder #57513

Closed
dmitshur opened this issue Dec 29, 2022 · 3 comments
Closed

x/build/dashboard: add js-wasm-node18 builder #57513

dmitshur opened this issue Dec 29, 2022 · 3 comments
Labels
arch-wasm WebAssembly issues Builders x/build issues (builders, bots, dashboards) FrozenDueToAge new-builder OS-JS
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

The current "js-wasm" builder tests using Node.js 14 (as of August 2021; see CL 338730). From looking at https://nodejs.org/en/about/releases, there are newer Node.js releases available by now, and Node.js 14 will reach EOL on 2023-04-30.

This is the tracking issue for adding a js/wasm builder with a newer Node.js release.

It seems Node.js 18 will have longer LTS support than Node.js 19 and the https://nodejs.org page describes it as "Recommended For Most Users", so it looks like a good choice for the next version. I've titled this issue accordingly.

CC @golang/js, @golang/wasm, @golang/release.
@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) arch-wasm WebAssembly issues new-builder OS-JS labels Dec 29, 2022
@dmitshur dmitshur added this to the Unreleased milestone Dec 29, 2022
@gopherbot
Copy link

Change https://go.dev/cl/460036 mentions this issue: dashboard, env: add js-wasm-node18 builder

@agnivade
Copy link
Contributor

Duplicate of #57017?

@dmitshur
Copy link
Contributor Author

@agnivade Thanks, I missed that unfortunately (it didn't have CC @golang/release nor a new-builder label). I'll update my CL to use that issue.

@dmitshur dmitshur closed this as not planned Won't fix, can't repro, duplicate, stale Dec 29, 2022
@golang golang locked and limited conversation to collaborators Dec 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-wasm WebAssembly issues Builders x/build issues (builders, bots, dashboards) FrozenDueToAge new-builder OS-JS
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@agnivade @dmitshur @gopherbot