Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: go list diagnostics do not work for individual modules when go.work is used #57509

Open
findleyr opened this issue Dec 29, 2022 · 0 comments
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@findleyr
Copy link
Contributor

gopls has various logic that extracts information from the original go list invocation (see goCommandDiagnostics). In particular, it looks for errors related to go.sum entries.

When using a go.work file, (1) the go.work.sum is automatically updated, contrary to the behavior with respect to go.sum files, and (2) gopls does not get errors about individual go.sum files that may be out of sync.

Low priority, but we should resolve this inconsistency. Ideally, we could separate the calculation of these diagnostics from the actual go/packages.Load invocation. Having them coupled is problematic.

CC @adonovan @bcmills

@findleyr findleyr added this to the gopls/later milestone Dec 29, 2022
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

2 participants