-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: incorrect type set intersection computation [1.19 backport] #57499
Comments
Change https://go.dev/cl/460016 mentions this issue: |
This seems like a low-severity problem, and last time we backported a fix like this, for sync.Atomic, it caused some collateral damage. Is there a compelling case to not just wait for 1.20 in a few weeks? |
The primary reason for backporting would be for people who cannot (or don't want to) move to 1.20. People using 1.18 and and 1.19 can write code that the compiler accepts but that is in fact incorrect (though I don't have a simple example where such incorrectly compiled code can be used to exploit something - it'll take some ingenuity to find such an example). The actual fix in the type checker is extremely straight-forward - most of the rest of the CL is simply for the test cases. I'm not worried too much about collateral damage. My take: if there's no more point release for 1.18 and 1.19, then let's not do this. If there are point releases for other reasons, then let's include this fix. |
We have a track record of all kinds of trouble with generics changes, even very innocuous-looking ones. This is a low-severity issue, and we're trying to be more conservative, so we decided to decline this one. Sorry. |
@griesemer requested issue #57486 to be considered for backport to the next 1.19 minor release.
The text was updated successfully, but these errors were encountered: