Skip to content

x/build/dashboard: add OpenBSD 7.1 and 7.2 builders (for 386, amd64) #57496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dmitshur opened this issue Dec 28, 2022 · 7 comments
Closed

x/build/dashboard: add OpenBSD 7.1 and 7.2 builders (for 386, amd64) #57496

dmitshur opened this issue Dec 28, 2022 · 7 comments
Assignees
@qbit @dmitshur
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. new-builder OS-OpenBSD
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Dec 28, 2022 •
edited
Loading

OpenBSD 7.2 has been released.
This is a tracking issue for adding OpenBSD 7.1 and 7.2 builders for amd64 and 386 architectures.
This is in progress, see https://go.dev/cl/456295.

CC @golang/release, @golang/openbsd.
@dmitshur dmitshur added OS-OpenBSD Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. new-builder labels Dec 28, 2022
@dmitshur dmitshur self-assigned this Dec 28, 2022
@dmitshur dmitshur moved this to In Progress in Go Release Dec 28, 2022
@gopherbot gopherbot added this to the Unreleased milestone Dec 28, 2022
@dmitshur dmitshur mentioned this issue Dec 28, 2022
Closed
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/456295 mentions this issue: env,dashboard: add OpenBSD 7.1 and 7.2

@dmitshur
Copy link
Contributor Author

dmitshur commented Dec 29, 2022 •
edited
Loading

I've deployed these builders last night and they had a chance to produce results. It looks to be working well to me. All golang.org/x repo tests are passing, and mostly passing on the main repo. There are some failures on OpenBSD 7.1 that might be related to #55161.

As far as I can tell, it seems fine to remove the known issue and switch trybots from 7.0 to 7.2. And, we should remove the <= 7.0 builders after that too (fine to do in a separate CL or all at once).

@qbit Would you like to send CLs to take those next steps here and I can review?

@qbit
Copy link
Member

qbit commented Dec 29, 2022

Sure, I'll get that sent off here in a sec.

gopherbot pushed a commit to golang/build that referenced this issue Dec 29, 2022
@qbit @gopherbot
env,dashboard: add OpenBSD 7.1 and 7.2
85db05f 
While here modify make.bash to accept a VERSION variable.

For golang/go#55161.
For golang/go#57496.

Change-Id: I395af9cfa59e38757635c9dd703ef292c8b35a87
GitHub-Last-Rev: e2dd699
GitHub-Pull-Request: #49
Reviewed-on: https://go-review.googlesource.com/c/build/+/456295
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
qbit added a commit to qbit/build that referenced this issue Dec 29, 2022
@qbit
dashboard: remove EOL OpenBSD <= 7.0, switch trybots from 7.0 to 7.2
689b56d 
For golang/go#57496
@qbit qbit mentioned this issue Dec 29, 2022
Closed
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/459995 mentions this issue: dashboard: remove EOL OpenBSD <= 7.0, switch trybots from 7.0 to 7.2

@github-project-automation github-project-automation bot moved this from In Progress to Done in Go Release Jan 3, 2023
@bcmills bcmills mentioned this issue Jan 5, 2023
Closed
@4a6f656c
Copy link
Contributor

@dmitshur @qbit

I'm a bit late to this party, however as things stand we will not be able to run OpenBSD 7.1 builders - there is a kernel kqueue bug that got fixed upstream, however there is currently no errata for it:

http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sys/kern/kern_event.c.diff?r1=1.188&r2=1.189

This means we would either a custom kernel with this diff, or we would need to get this released as OpenBSD errata.

@qbit
Copy link
Member

qbit commented Jan 10, 2023

Oh bummer. Well, should we disable the 7.1 builders? Not sure a 7.1 errata would fly.. but I don't have much insight into that side of things :D .

@dmitshur
Copy link
Contributor Author

Thanks Joel. To me, disabling (or removing, really) 7.1 builders seems fine, and that would resolve #57585. I'll let OpenBSD port owners follow up as you prefer. Please file a new issue for anything that needs to happen.

@golang golang locked and limited conversation to collaborators Jan 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@qbit qbit

@dmitshur dmitshur

Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. new-builder OS-OpenBSD
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

Successfully merging a pull request may close this issue.

dashboard: remove EOL OpenBSD <= 7.0, switch trybots from 7.0 to 7.2 qbit/build
4 participants
@qbit @dmitshur @4a6f656c @gopherbot