Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/playground: selecting Go dev branch uses arbitrary older version #57495

Closed
rittneje opened this issue Dec 28, 2022 · 7 comments
Closed

x/playground: selecting Go dev branch uses arbitrary older version #57495

rittneje opened this issue Dec 28, 2022 · 7 comments
Assignees
@findleyr
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@rittneje
Copy link

What did you do?

Ran a sample program to get the version that the playground uses for "Go dev branch" (aka gotip). https://go.dev/play/p/V9tVDS4adLm?v=gotip

What did you expect to see?

I expected to see it report some reasonably recent commit of the master branch.

What did you see instead?

It reported commit 537c435, which is from October.
@gopherbot gopherbot added this to the Unreleased milestone Dec 28, 2022
@dmitshur
Copy link
Contributor

Thanks for reporting.

The 1.19 and 1.18 branches may also be affected: running that program with Go 1.19/Go 1.18 in the dropdown prints go1.19.2/go1.18.8 (while Go 1.19.4 and 1.18.9 are the latest minor releases right now).

CC @toothrot, @findleyr.

@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 28, 2022
@rittneje
Copy link
Author

rittneje commented Dec 29, 2022 •
edited

The is discrepancy b/w the timing of the commits as well. In playground its reported as Oct 28 but in git log its july 11

@goferHiro July 11 is the author date. The commit date is October 28 (UTC), which aligns with what runtime.Version() is reporting. See here for more details on the distinction.

@findleyr
Copy link
Contributor

findleyr commented Jan 4, 2023

Looked at this today. The 1.18 and 1.19 deployment failures were unrelated (we hit a GCP resource limit). This is now fixed, and both are updated.

The tip failure appears to be related to https://go.dev/cl/432535. My knowledge of this is vague, but since builds don't share GOCACHE I think they're all rebuilding std, and health checks (which do a build) are timing out. Presumably we need to add a shared cache for the build.

CC @bcmills @matloob

@gopherbot
Copy link

Change https://go.dev/cl/460635 mentions this issue: playground: copy a buildcache containing std archives on each build

@findleyr findleyr self-assigned this Jan 5, 2023
gopherbot pushed a commit to golang/playground that referenced this issue Jan 5, 2023
@findleyr
playground: copy a build cache containing std archives on each build
972afd6 
Following CL 432535, archive files for std are not included in GOROOT.
As a result, the playground had to recompile the relevant parts of std
on each build, causing it to time out during health checks.

Try to fix this by copying a minimal amount of GOCACHE content for each
build, rather than recompiling. Use hard linking to avoid copying bytes.

For golang/go#57495

Change-Id: I06bf9f2630d1f9e4675847586911b45054d05222
Reviewed-on: https://go-review.googlesource.com/c/playground/+/460635
Reviewed-by: Heschi Kreinick <heschi@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
@findleyr
Copy link
Contributor

findleyr commented Jan 5, 2023

This is now fixed.

@findleyr findleyr closed this as completed Jan 5, 2023
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jan 5, 2023
@golang golang locked and limited conversation to collaborators Jan 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@findleyr findleyr

Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@dmitshur @gopherbot @rittneje @findleyr and others