Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: allow to install cross-compiled binaries when GOBIN is set #57485

Open
hyangah opened this issue Dec 27, 2022 · 7 comments · May be fixed by #66065
Open

cmd/go: allow to install cross-compiled binaries when GOBIN is set #57485

hyangah opened this issue Dec 27, 2022 · 7 comments · May be fixed by #66065
Labels
FeatureRequest GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@hyangah
Copy link
Contributor

hyangah commented Dec 27, 2022 

$ GOBIN=/tmp/release GOOS=linux GOARCH=amd64 CGO_ENABLED=0 go1.20rc1 install golang.org/dl/go1.19.4@latest
go: cannot install cross-compiled binaries when GOBIN is set

What version of Go are you using (go version)?

$ go version
go version go1.19.4 darwin/amd64

What did you do?

Want to build a go tool for a different platform, but want the compiled binary to be in a directory different from my default installation directory.

What did you expect to see?

Successfully cross-compile the binary and have the result somewhere under GOBIN.

What did you see instead?

Error.

I believe the rejection of cross-compiled binary when GOBIN is set has a long history, that predates both Go modules and the recent major change in the meaning of go install <main_package_path>@<version> repurposed for clean tool installation. There were multiple related discussion topics (#13063 #14295 #9769) but all were closed as "FrozenDueToAge".

An alternative is to support -o flag for go install or go build <main_package>@<version> which is under discussion in a different context. #44469.
@dmitshur
Copy link
Contributor

CC @bcmills, @matloob.

@dmitshur dmitshur added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. FeatureRequest GoCommand cmd/go labels Dec 28, 2022
@dmitshur dmitshur added this to the Backlog milestone Dec 28, 2022
@bcmills
Copy link
Contributor

bcmills commented Feb 6, 2023

We had some confusion around the semantics of GOBIN circa Go 1.13 that resulted in a bit of a shift, which seems to have stuck.

I agree that, given the current semantics (and especially given the current interop stories around CPU migrations on various vendors), it seems fine to allow go install to install cross-compiled binaries to GOBIN.

@mstoykov mstoykov mentioned this issue Sep 7, 2023
Closed
@kylelemons
Copy link
Contributor

We're also running into this. We're working on tooling to improve the development cycle time for Kubernetes microservices, and the binaries run in Linux in the cluster but most developers are building on M1. Being able to GOBIN=path GOOS=linux GOARCH=amd64 go install ./... makes the tooling able to be a lot simpler.

Any chance this could be reviewed by the proposal review committee?

@aleskandro aleskandro mentioned this issue Jan 25, 2024
Open
@jxlxx jxlxx linked a pull request Mar 1, 2024 that will close this issue
Open
@gopherbot
Copy link

Change https://go.dev/cl/568396 mentions this issue: cmd/go/internal/work: allows installing cross-compiled binaries GOBIN is set

@oliverpool oliverpool mentioned this issue Mar 2, 2024
Open
@rsc
Copy link
Contributor

rsc commented Mar 6, 2024

I think the GOBIN behavior is correct, because otherwise we risk smashing people's local binaries accidentally when GOBIN=$HOME/bin. But I think adding a -o flag to go install makes a lot of sense.

@seankhliao
Copy link
Member

Wouldn't doing #44469 go build -o out pkg@ver make more sense?

@rsc
Copy link
Contributor

rsc commented Mar 8, 2024

Perhaps. One or the other.

@jakirkham jakirkham mentioned this issue Mar 21, 2024
Merged
@tdeebswihart tdeebswihart mentioned this issue Apr 2, 2024
Merged
@kengou kengou mentioned this issue Apr 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FeatureRequest GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

cmd/go/internal/work: allows installing cross-compiled binaries GOBIN is set jxlxx/go
7 participants
@rsc @kylelemons @dmitshur @hyangah @bcmills @gopherbot @seankhliao