Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cover: TestParseProfiles timeouts #57481

Closed
gopherbot opened this issue Dec 27, 2022 · 4 comments
Closed

x/tools/cover: TestParseProfiles timeouts #57481

gopherbot opened this issue Dec 27, 2022 · 4 comments
Assignees
@bcmills
Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link

gopherbot commented Dec 27, 2022 •
edited by bcmills 

#!watchflakes
post <- pkg == "golang.org/x/tools/cover" && test == "TestParseProfiles" && log ~ `panic: test timed out`

Issue created automatically to collect these failures.

Example (log):

panic: test timed out after 10m0s
running tests:
	TestParseProfiles (10m0s)
	TestParseProfiles/simple_valid_file_produces_expected_output (3m39s)

testing.(*T).Run(0xc0000829c0, {0x53a235?, 0x5bbc3f?}, 0xc00009e270)
	/tmp/workdir-host-linux-amd64-wsl/go/src/testing/testing.go:1630 +0x405
golang.org/x/tools/cover.TestParseProfiles(0x0?)
	/tmp/workdir-host-linux-amd64-wsl/gopath/src/golang.org/x/tools/cover/profile_test.go:210 +0x80c
testing.tRunner(0xc0000829c0, 0x53d260)

— watchflakes
@gopherbot gopherbot added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository. labels Dec 27, 2022
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/cover" && test == "TestParseProfiles"
2022-12-22 18:22 linux-amd64-wsl tools@6546d82b go@38cfb3be x/tools/cover.TestParseProfiles (log) 
panic: test timed out after 10m0s
running tests:
	TestParseProfiles (10m0s)
	TestParseProfiles/simple_valid_file_produces_expected_output (3m39s)

testing.(*T).Run(0xc0000829c0, {0x53a235?, 0x5bbc3f?}, 0xc00009e270)
	/tmp/workdir-host-linux-amd64-wsl/go/src/testing/testing.go:1630 +0x405
golang.org/x/tools/cover.TestParseProfiles(0x0?)
	/tmp/workdir-host-linux-amd64-wsl/gopath/src/golang.org/x/tools/cover/profile_test.go:210 +0x80c
testing.tRunner(0xc0000829c0, 0x53d260)

— watchflakes

@gopherbot gopherbot added this to the Unreleased milestone Dec 27, 2022
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/cover" && test == "TestParseProfiles"
2023-05-05 16:38 linux-amd64-wsl tools@8e9b1853 go@324c3ace x/tools/cover.TestParseProfiles (log) 
panic: test timed out after 10m0s
running tests:
	TestParseProfiles (10m0s)
	TestParseProfiles/parsing_an_empty_file_produces_empty_output (10m0s)

testing.(*T).Run(0xc000082d00, {0x53c819?, 0x5bef06?}, 0xc000096650)
	/tmp/workdir-host-linux-amd64-wsl/go/src/testing/testing.go:1630 +0x405
golang.org/x/tools/cover.TestParseProfiles(0x0?)
	/tmp/workdir-host-linux-amd64-wsl/gopath/src/golang.org/x/tools/cover/profile_test.go:210 +0x80c
testing.tRunner(0xc000082d00, 0x53f748)

— watchflakes

@bcmills bcmills changed the title x/tools/cover: TestParseProfiles failures x/tools/cover: TestParseProfiles timeouts May 17, 2023
@bcmills
Copy link
Contributor

bcmills commented May 17, 2023

Both on -wsl, and both stuck in syscall.Fsync. But Fsync seems really heavy-handed for this test. 🤔

@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels May 17, 2023
@bcmills bcmills self-assigned this May 17, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/495798 mentions this issue: cover: eliminate an unnecessary fsync in TestParseProfiles

@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bcmills bcmills

Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bcmills @gopherbot