Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: TestDialTimeout failures #57475

Closed
gopherbot opened this issue Dec 27, 2022 · 8 comments
Closed

net: TestDialTimeout failures #57475

gopherbot opened this issue Dec 27, 2022 · 8 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@gopherbot
Copy link

gopherbot commented Dec 27, 2022

#!watchflakes
post <- pkg == "net" && test == "TestDialTimeout" && `Dial didn't return in an expected time`

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestDialTimeout (1.21s)
    timeout_test.go:83: #7: Dial didn't return in an expected time

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 27, 2022
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net" && test == "TestDialTimeout"
2022-12-19 21:45 darwin-amd64-11_0 go@da744b19 net.TestDialTimeout (log)
--- FAIL: TestDialTimeout (1.21s)
    timeout_test.go:83: #7: Dial didn't return in an expected time

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net" && test == "TestDialTimeout"
2022-12-09 20:04 darwin-amd64-10_15 go@c2a2fbab net.TestDialTimeout (log)
--- FAIL: TestDialTimeout (1.12s)
    timeout_test.go:83: #6: Dial didn't return in an expected time

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net" && test == "TestDialTimeout"
2023-02-03 19:01 darwin-amd64-12_0 go@cd1fc871 net.TestDialTimeout (log)
--- FAIL: TestDialTimeout (1.00s)
    timeout_test.go:83: #5: Dial didn't return in an expected time

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net" && test == "TestDialTimeout"
2023-02-04 02:26 darwin-amd64-13 go@82e04653 net.TestDialTimeout (log)
--- FAIL: TestDialTimeout (1.21s)
    timeout_test.go:83: #7: Dial didn't return in an expected time

watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net" && test == "TestDialTimeout"
2023-02-23 06:09 darwin-amd64-12_0 go@ecff9c93 net.TestDialTimeout (log)
--- FAIL: TestDialTimeout (1.00s)
    timeout_test.go:83: #5: Dial didn't return in an expected time

watchflakes

@bcmills
Copy link
Contributor

bcmills commented Mar 14, 2023

(attn @ianlancetaylor @neild)

@ianlancetaylor
Copy link
Contributor

All reported failures are on darwin-amd64. The failures are all tests 5, 6, 7. These tests all set up a dial using a test hook that sleeps for 100 milliseconds and then returns an error (there is no actual call to syscall.Connect). The error occurs when a 1 second timer fires before the dial completes. I don't see any system calls here so the only obvious way that this could fail would be if the 1 second timer fires before the 100 millisecond timeout completes. Not sure how that correlates to darwin-amd64.

@gopherbot
Copy link
Author

Change https://go.dev/cl/476356 mentions this issue: net: remove max timeout from TestDialTimeout

@golang golang locked and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Status: Done
Development

No branches or pull requests

3 participants