Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/link: need to handle new-style LoongArch relocs [1.19 backport] #57444

Closed
gopherbot opened this issue Dec 22, 2022 · 4 comments
Closed

cmd/link: need to handle new-style LoongArch relocs [1.19 backport] #57444

gopherbot opened this issue Dec 22, 2022 · 4 comments
Assignees
@cherrymui
Labels
arch-loong64 Issues solely affecting the loongson architecture. CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Milestone
Go1.19.5

Comments

@gopherbot
Copy link

@dr2chase requested issue #54222 to be considered for backport to the next 1.19 minor release.

@gopherbot please open backport issues.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Dec 22, 2022
@gopherbot gopherbot mentioned this issue Dec 22, 2022
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Dec 22, 2022
@gopherbot gopherbot added this to the Go1.19.5 milestone Dec 22, 2022
@dr2chase
Copy link
Contributor

This already has a fix, ready to go and approved by Loong, by the @cherrymui .
https://go.dev/cl/458836
This fixes a persistently broken test on linux-loong64 with the newer GNU toolchain.

@gopherbot
Copy link
Author

Change https://go.dev/cl/458836 mentions this issue: [release-branch.go1.19] cmd/link: recognize the new R_LARCH_32_PCREL type on loong64

@dmitshur
Copy link
Contributor

Approved. This minimal backport is needed to fix the loong64 builder on the 1.19 release branch. Only 1.19 needs this fix.

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Dec 28, 2022
@gopherbot
Copy link
Author

Closed by merging 24963e5 to release-branch.go1.19.

gopherbot pushed a commit that referenced this issue Dec 28, 2022
@cherrymui @gopherbot
[release-branch.go1.19] cmd/link: recognize the new R_LARCH_32_PCREL …
24963e5 
…type on loong64

This is a minimum backport of CL 420983 without an API change in
debug/elf.

Original CL description:

Due to the latest binutils change [1], at least for certain 32-bit
relocs in .eh_frame section, this new type of relocation record is
emitted, leading to breakage on systems with bleeding-edge toolchain
when trying to link with object(s) with such new-style relocs.

Simply treating it the same as the existing reloc types seems enough.

Updates #54222.
Fixes #57444.

[1]: https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=f09482a8747b6fd4c2d59a6a64677d3a3fe1e092

Change-Id: Idd86294a11c1d13b88acbca59e537656a57d8109
Reviewed-on: https://go-review.googlesource.com/c/go/+/458836
Reviewed-by: WANG Xuerui <git@xen0n.name>
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: David Chase <drchase@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Cherry Mui <cherryyz@google.com>
@dmitshur dmitshur added the arch-loong64 Issues solely affecting the loongson architecture. label Dec 28, 2022
@golang golang locked and limited conversation to collaborators Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cherrymui cherrymui

Labels
arch-loong64 Issues solely affecting the loongson architecture. CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Projects
None yet
Milestone
Go1.19.5
Development

No branches or pull requests
4 participants
@dmitshur @dr2chase @gopherbot @cherrymui