New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/link: dead importcycle code #57400
Labels
Milestone
Comments
jquirke
changed the title
proposal: cmd/link remove unused importcycle path
proposal: cmd/link remove dead importcycle code
Dec 20, 2022
Change https://go.dev/cl/458436 mentions this issue: |
mdlayher
changed the title
proposal: cmd/link remove dead importcycle code
cmd/link: dead importcycle code
Dec 20, 2022
gopherbot
added
the
compiler/runtime
Issues related to the Go compiler and/or runtime.
label
Dec 20, 2022
jquirke
added a commit
to jquirke/go
that referenced
this issue
Dec 20, 2022
The importcycles method has not been useful since April 2016 when a large code deletion was performed. The compiler itself provides some protection against import cycles, and the linker now does import cycle detection in linksetup -> postorder. For golang#57400
Thanks for spotting this. For things like this, you can just send a CL without filing an issue. Thanks. |
jquirke
added a commit
to jquirke/go
that referenced
this issue
Dec 26, 2022
The importcycles method has not been useful since April 2016 when a large code deletion was performed. The compiler itself provides some protection against import cycles, and the linker now does import cycle detection in linksetup -> postorder. For golang#57400
jquirke
added a commit
to jquirke/go
that referenced
this issue
Dec 26, 2022
The importcycles method has not been useful since April 2016 when a large code deletion was performed. The compiler itself provides some protection against import cycles, and the linker now does import cycle detection in linksetup -> postorder. For golang#57400
Change https://go.dev/cl/459475 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Jan 24, 2023
The importcycles method has not been useful since April 2016 when a large code deletion was performed. The compiler itself provides some protection against import cycles, and the linker does import cycle detection in linksetup -> postorder. For #57400 Change-Id: I3095bdb3f16a82ba25681bf4a20ceaa3c9613921 GitHub-Last-Rev: 87a4615 GitHub-Pull-Request: #57462 Reviewed-on: https://go-review.googlesource.com/c/go/+/459475 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Than McIntosh <thanm@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com> Run-TryBot: Cherry Mui <cherryyz@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Remove dead code importcycles() function.
This was originally introduced in 2011 in CL https://codereview.appspot.com/4812053 for Issue 2052.
All consumers of this code were removed in a cleanup in 2016 https://go-review.googlesource.com/c/go/+/21782 and it performs no function whatsoever.
Furthermore:
go/src/cmd/link/internal/ld/lib.go
Line 2558 in fe67a21
The text was updated successfully, but these errors were encountered: