Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/lsp/cmd: TestCapabilities failures #57373

Closed
gopherbot opened this issue Dec 17, 2022 · 7 comments
Closed

x/tools/gopls/internal/lsp/cmd: TestCapabilities failures #57373

gopherbot opened this issue Dec 17, 2022 · 7 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.12.0

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/cmd" && test == "TestCapabilities"

Issue created automatically to collect these failures.

Example (log):

2022/12/13 08:12:07 New session
	create_session=1
2022/12/13 08:12:08 go env for /tmp/buildlet/tmp/fake2461221797
(root /tmp/buildlet/tmp/fake2461221797)
(go version go version devel b16e94d13d0f9b84ed92563a12984190f91ead66 darwin/amd64)
(valid build configuration = true)
(build flags: [])
GOINSECURE=
GOPROXY=https://proxy.golang.org
GO111MODULE=
...
panic: test timed out after 10m0s
running tests:
	TestCapabilities (10m0s)

sync.runtime_Semacquire(0x1006da525?)
	/tmp/buildlet/go/src/runtime/sema.go:62 +0x27
sync.(*WaitGroup).Wait(0xc0000d6fc0?)
	/tmp/buildlet/go/src/sync/waitgroup.go:116 +0x4b
golang.org/x/tools/gopls/internal/lsp/cache.(*View).shutdown(0xc000002780)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/view.go:591 +0x118
golang.org/x/tools/gopls/internal/lsp/cache.(*Session).Shutdown(0xc00026c770, {0x100b5d958, 0xc00003c070})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/session.go:151 +0x170
golang.org/x/tools/gopls/internal/lsp.(*Server).shutdown(0xc00025a200, {0x100b5d958, 0xc00003c070})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/general.go:595 +0x10e
golang.org/x/tools/gopls/internal/lsp.(*Server).Shutdown(0xc000044480?, {0x100b5d958?, 0xc00003c070?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/server_gen.go:272 +0x25
golang.org/x/tools/gopls/internal/lsp/cmd.TestCapabilities(0xc0002681a0)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/capabilities_test.go:147 +0xf36
testing.tRunner(0xc0002681a0, 0x100a7ec70)

— watchflakes
@gopherbot gopherbot added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Dec 17, 2022
@gopherbot gopherbot added this to the Unreleased milestone Dec 17, 2022
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/cmd" && test == "TestCapabilities"
2022-12-13 13:03 darwin-amd64-11_0 tools@d72a64a9 go@b16e94d1 x/tools/gopls/internal/lsp/cmd.TestCapabilities (log) 
2022/12/13 08:12:07 New session
	create_session=1
2022/12/13 08:12:08 go env for /tmp/buildlet/tmp/fake2461221797
(root /tmp/buildlet/tmp/fake2461221797)
(go version go version devel b16e94d13d0f9b84ed92563a12984190f91ead66 darwin/amd64)
(valid build configuration = true)
(build flags: [])
GOINSECURE=
GOPROXY=https://proxy.golang.org
GO111MODULE=
...
panic: test timed out after 10m0s
running tests:
	TestCapabilities (10m0s)

sync.runtime_Semacquire(0x1006da525?)
	/tmp/buildlet/go/src/runtime/sema.go:62 +0x27
sync.(*WaitGroup).Wait(0xc0000d6fc0?)
	/tmp/buildlet/go/src/sync/waitgroup.go:116 +0x4b
golang.org/x/tools/gopls/internal/lsp/cache.(*View).shutdown(0xc000002780)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/view.go:591 +0x118
golang.org/x/tools/gopls/internal/lsp/cache.(*Session).Shutdown(0xc00026c770, {0x100b5d958, 0xc00003c070})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/session.go:151 +0x170
golang.org/x/tools/gopls/internal/lsp.(*Server).shutdown(0xc00025a200, {0x100b5d958, 0xc00003c070})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/general.go:595 +0x10e
golang.org/x/tools/gopls/internal/lsp.(*Server).Shutdown(0xc000044480?, {0x100b5d958?, 0xc00003c070?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/server_gen.go:272 +0x25
golang.org/x/tools/gopls/internal/lsp/cmd.TestCapabilities(0xc0002681a0)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/capabilities_test.go:147 +0xf36
testing.tRunner(0xc0002681a0, 0x100a7ec70)

— watchflakes

@hyangah hyangah modified the milestones: Unreleased, gopls/v0.12.0 Dec 22, 2022
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/cmd" && test == "TestCapabilities"
2023-04-20 20:04 illumos-amd64 tools@9c9e11f3 go@15c12762 x/tools/gopls/internal/lsp/cmd.TestCapabilities (log) 
2023/04/21 03:48:05 New session
	create_session=1
2023/04/21 03:48:05 go info for /var/tmp/workdir-host-illumos-amd64-jclulow/tmp/fake3758459182
(go dir /var/tmp/workdir-host-illumos-amd64-jclulow/tmp/fake3758459182)
(go version go version devel 15c12762466b4c5f92b1668f86f73d0b1e66b62b illumos/amd64)
(valid build configuration = true)
(build flags: [])
(selected go env: [GO111MODULE=, GOCACHE=/var/tmp/workdir-host-illumos-amd64-jclulow/gocache, GOFLAGS=, GOMODCACHE=/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/pkg/mod, GOPATH=/var/tmp/workdir-host-illumos-amd64-jclulow/gopath, GOPRIVATE=, GOROOT=/var/tmp/workdir-host-illumos-amd64-jclulow/go, GOWORK=])

2023/04/21 03:48:05 go/packages.Load #1
...
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/analysis.go:210 +0x3b0 fp=0xc000161090 sp=0xc000160dd0 pc=0xaa93f0
golang.org/x/tools/gopls/internal/lsp/source.Analyze({0xfbd2c0, 0x1506c20}, {0xfc6990, 0xc0002d89a0}, {0xc00044fe48, 0x4}, 0x1)
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/tools/gopls/internal/lsp/source/diagnostics.go:46 +0x25d fp=0xc0001611c0 sp=0xc000161090 pc=0x9ddebd
golang.org/x/tools/gopls/internal/lsp.(*Server).codeAction(0x40e665?, {0xfbd2c0?, 0x1506c20?}, 0xc0002cc8c0)
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/tools/gopls/internal/lsp/code_action.go:194 +0x1589 fp=0xc000161bd8 sp=0xc0001611c0 pc=0xb45709
golang.org/x/tools/gopls/internal/lsp.(*Server).CodeAction(0xc000206500?, {0xfbd2c0?, 0x1506c20?}, 0x0?)
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/tools/gopls/internal/lsp/server_gen.go:16 +0x1d fp=0xc000161c08 sp=0xc000161bd8 pc=0xb6d45d
golang.org/x/tools/gopls/internal/lsp/cmd.TestCapabilities(0xc00024a820)
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/capabilities_test.go:93 +0xac2 fp=0xc000161f70 sp=0xc000161c08 pc=0xb93342
testing.tRunner(0xc00024a820, 0xed1a20)
2023-04-20 20:04 illumos-amd64 tools@9c9e11f3 go@ecf7e00d x/tools/gopls/internal/lsp/cmd.TestCapabilities (log) 
2023/04/21 06:08:46 New session
	create_session=1
2023/04/21 06:08:46 go info for /var/tmp/workdir-host-illumos-amd64-jclulow/tmp/fake1701943714
(go dir /var/tmp/workdir-host-illumos-amd64-jclulow/tmp/fake1701943714)
(go version go version go1.20.3 illumos/amd64)
(valid build configuration = true)
(build flags: [])
(selected go env: [GO111MODULE=, GOCACHE=/var/tmp/workdir-host-illumos-amd64-jclulow/gocache, GOFLAGS=, GOMODCACHE=/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/pkg/mod, GOPATH=/var/tmp/workdir-host-illumos-amd64-jclulow/gopath, GOPRIVATE=, GOROOT=/var/tmp/workdir-host-illumos-amd64-jclulow/go, GOWORK=])

2023/04/21 06:08:47 go/packages.Load #1
...
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/analysis.go:210 +0x3b4 fp=0xc0000e9088 sp=0xc0000e8dc0 pc=0xaf0974
golang.org/x/tools/gopls/internal/lsp/source.Analyze({0x100b968, 0xc00003e078}, {0x1015550, 0xc0002d0840}, {0xc0003dc7f8, 0x4}, 0x1)
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/tools/gopls/internal/lsp/source/diagnostics.go:46 +0x25e fp=0xc0000e91b8 sp=0xc0000e9088 pc=0xa1eabe
golang.org/x/tools/gopls/internal/lsp.(*Server).codeAction(0x40f827?, {0x100b968?, 0xc00003e078?}, 0xc000225f10)
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/tools/gopls/internal/lsp/code_action.go:194 +0x15f8 fp=0xc0000e9bd0 sp=0xc0000e91b8 pc=0xb91978
golang.org/x/tools/gopls/internal/lsp.(*Server).CodeAction(0xc00019c640?, {0x100b968?, 0xc00003e078?}, 0x0?)
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/tools/gopls/internal/lsp/server_gen.go:16 +0x25 fp=0xc0000e9c00 sp=0xc0000e9bd0 pc=0xbba9a5
golang.org/x/tools/gopls/internal/lsp/cmd.TestCapabilities(0xc000206820)
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/capabilities_test.go:93 +0xaf0 fp=0xc0000e9f70 sp=0xc0000e9c00 pc=0xbe2530
testing.tRunner(0xc000206820, 0xf1dda0)
2023-04-20 20:04 illumos-amd64 tools@9c9e11f3 go@bdccb85f x/tools/gopls/internal/lsp/cmd.TestCapabilities (log) 
2023/04/21 05:17:31 New session
	create_session=1
2023/04/21 05:17:31 go info for /var/tmp/workdir-host-illumos-amd64-jclulow/tmp/fake1587311359
(go dir /var/tmp/workdir-host-illumos-amd64-jclulow/tmp/fake1587311359)
(go version go version devel bdccb85f509d24789694df198fe7bde948aa7955 illumos/amd64)
(valid build configuration = true)
(build flags: [])
(selected go env: [GO111MODULE=, GOCACHE=/var/tmp/workdir-host-illumos-amd64-jclulow/gocache, GOFLAGS=, GOMODCACHE=/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/pkg/mod, GOPATH=/var/tmp/workdir-host-illumos-amd64-jclulow/gopath, GOPRIVATE=, GOROOT=/var/tmp/workdir-host-illumos-amd64-jclulow/go, GOWORK=])

2023/04/21 05:17:31 go/packages.Load #1
...
panic: test timed out after 10m0s
running tests:
	TestCapabilities (10m13s)

golang.org/x/tools/internal/memoize.(*Promise).wait(0xc000357440, {0xfbd2a0, 0x1506c00})
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/tools/internal/memoize/memoize.go:218 +0xdd
golang.org/x/tools/internal/memoize.(*Promise).run(0xc000357440, {0xfbd2a0, 0x1506c00}, {0xd6ef60?, 0xc0001f7e40})
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/tools/internal/memoize/memoize.go:209 +0x1de
golang.org/x/tools/internal/memoize.(*Promise).Get(0xc000357440, {0xfbd2a0, 0x1506c00}, {0xd6ef60, 0xc0001f7e40})
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/tools/internal/memoize/memoize.go:154 +0x19a
...
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/analysis.go:210 +0x3b0
golang.org/x/tools/gopls/internal/lsp/source.Analyze({0xfbd2a0, 0x1506c00}, {0xfc6970, 0xc0001f7e40}, {0xc000257e7c, 0x4}, 0x1)
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/tools/gopls/internal/lsp/source/diagnostics.go:46 +0x25d
golang.org/x/tools/gopls/internal/lsp.(*Server).codeAction(0x40e665?, {0xfbd2a0?, 0x1506c00?}, 0xc0002b7650)
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/tools/gopls/internal/lsp/code_action.go:194 +0x1589
golang.org/x/tools/gopls/internal/lsp.(*Server).CodeAction(0xc0002a0000?, {0xfbd2a0?, 0x1506c00?}, 0x0?)
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/tools/gopls/internal/lsp/server_gen.go:16 +0x1d
golang.org/x/tools/gopls/internal/lsp/cmd.TestCapabilities(0xc0002921a0)
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/capabilities_test.go:93 +0xac2
testing.tRunner(0xc0002921a0, 0xed1a20)

— watchflakes

@findleyr findleyr mentioned this issue May 3, 2023
Closed
@findleyr
Copy link
Contributor

findleyr commented May 3, 2023

Dupe of #59950 and #54461.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale May 3, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/cmd" && test == "TestCapabilities"
2023-08-09 19:07 plan9-arm tools@59fd05da go@58447d75 x/tools/gopls/internal/lsp/cmd.TestCapabilities (log) 
2023/08/09 20:28:02 New session
	create_session=1
2023/08/09 20:28:03 go info for /tmp/fake2192987956
(go dir /tmp/fake2192987956)
(go version go version devel 58447d757c233f2a9c3c5a73e2d96a6885f2759a plan9/arm)
(valid build configuration = true)
(build flags: [])
(selected go env: [GO111MODULE=, GOCACHE=/boot/cache, GOFLAGS=, GOMODCACHE=/boot/workdir/gopath/pkg/mod, GOPATH=/boot/workdir/gopath, GOPRIVATE=, GOROOT=/boot/workdir/go, GOWORK=])

2023/08/09 20:28:05 go/packages.Load #1
...
panic: test timed out after 30m0s
running tests:
	TestCapabilities (30m0s)

sync.runtime_Semacquire(0x995e768)
	/boot/workdir/go/src/runtime/sema.go:62 +0x3c
sync.(*WaitGroup).Wait(0x995e760)
	/boot/workdir/go/src/sync/waitgroup.go:116 +0x68
golang.org/x/tools/gopls/internal/lsp/cache.(*View).shutdown(0x995e690)
	/boot/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/view.go:671 +0xe0
golang.org/x/tools/gopls/internal/lsp/cache.(*Session).Shutdown(0x9a6e040, {0xba0a5c, 0x10203f0})
	/boot/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/session.go:79 +0x11c
golang.org/x/tools/gopls/internal/lsp.(*Server).shutdown(0x9a4c750, {0xba0a5c, 0x10203f0})
	/boot/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/general.go:627 +0x14c
golang.org/x/tools/gopls/internal/lsp.(*Server).Shutdown(0x9a4c750, {0xba0a5c, 0x10203f0})
	/boot/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/server_gen.go:264 +0x2c
golang.org/x/tools/gopls/internal/lsp/cmd.TestCapabilities(0x995e5a0)
	/boot/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/capabilities_test.go:156 +0xe3c
testing.tRunner(0x995e5a0, 0xaa4930)

— watchflakes

@gopherbot gopherbot reopened this Aug 17, 2023
@findleyr
Copy link
Contributor

Looks like a hanging go command, on plan9 this time.

CC @bcmills does this ring any bells?

@bcmills
Copy link
Contributor

bcmills commented Aug 17, 2023

If it's plan9, that's plausibly the exec / kill race under discussion in https://go.dev/cl/503455 (#60793).

@findleyr
Copy link
Contributor

Thanks, I'll defer to that discussion then.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Done
Milestone
gopls/v0.12.0
Development

No branches or pull requests
4 participants
@hyangah @bcmills @gopherbot @findleyr