Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/regtest/misc: TestFillStruct failures #57370

Closed
gopherbot opened this issue Dec 17, 2022 · 2 comments
Closed

x/tools/gopls/internal/regtest/misc: TestFillStruct failures #57370

gopherbot opened this issue Dec 17, 2022 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestFillStruct"

Issue created automatically to collect these failures.

Example (log):

serve.go:434: debug server listening at http://localhost:46081
serve.go:434: debug server listening at http://localhost:45083
2022/12/12 15:36:28 template: :9:109: executing "body" at <.Session.ID>: can't evaluate field Session in type *cache.View
server.go:3217: http: superfluous response.WriteHeader call from golang.org/x/tools/gopls/internal/lsp/debug.render.func1 (serve.go:666)
#### Start Gopls Test Logs for "TestFillStruct/experimental"
[Trace - 15:36:56.453 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/workdir/tmp/gopls-regtest-4273846445/TestFillStruct/experimental/gopath","GOPROXY":"file:///workdir/tmp/gopls-regtest-4273846445/TestFillStruct/experimental/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///workdir/tmp/gopls-regtest-4273846445/TestFillStruct/experimental/work","name":"work"}]}


[Trace - 15:36:56.453 PM] Received response 'initialize - (1)' in 0ms.
...
Params: {"command":"gopls.apply_fix","arguments":[{"Fix":"fill_struct","URI":"file:///workdir/tmp/gopls-regtest-4273846445/TestFillStruct/experimental/work/main.go","Range":{"start":{"line":8,"character":5},"end":{"line":8,"character":11}}}]}


[Error - Received] 15:36:56.571 PM #3 start: pos 98 is not in range for file [215:321)


#### End Gopls Test Logs for "TestFillStruct/experimental"
--- FAIL: TestFillStruct (0.48s)
    --- FAIL: TestFillStruct/experimental (0.15s)
        fix_test.go:42: no refactorings were applied

— watchflakes
@gopherbot gopherbot added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Dec 17, 2022
@gopherbot gopherbot added this to the Unreleased milestone Dec 17, 2022
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/misc" && test == "TestFillStruct"
2022-12-12 15:25 linux-386-longtest tools@a3eef259 go@27301e82 x/tools/gopls/internal/regtest/misc.TestFillStruct (log) 
serve.go:434: debug server listening at http://localhost:46081
serve.go:434: debug server listening at http://localhost:45083
2022/12/12 15:36:28 template: :9:109: executing "body" at <.Session.ID>: can't evaluate field Session in type *cache.View
server.go:3217: http: superfluous response.WriteHeader call from golang.org/x/tools/gopls/internal/lsp/debug.render.func1 (serve.go:666)
#### Start Gopls Test Logs for "TestFillStruct/experimental"
[Trace - 15:36:56.453 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/workdir/tmp/gopls-regtest-4273846445/TestFillStruct/experimental/gopath","GOPROXY":"file:///workdir/tmp/gopls-regtest-4273846445/TestFillStruct/experimental/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///workdir/tmp/gopls-regtest-4273846445/TestFillStruct/experimental/work","name":"work"}]}


[Trace - 15:36:56.453 PM] Received response 'initialize - (1)' in 0ms.
...
Params: {"command":"gopls.apply_fix","arguments":[{"Fix":"fill_struct","URI":"file:///workdir/tmp/gopls-regtest-4273846445/TestFillStruct/experimental/work/main.go","Range":{"start":{"line":8,"character":5},"end":{"line":8,"character":11}}}]}


[Error - Received] 15:36:56.571 PM #3 start: pos 98 is not in range for file [215:321)


#### End Gopls Test Logs for "TestFillStruct/experimental"
--- FAIL: TestFillStruct (0.48s)
    --- FAIL: TestFillStruct/experimental (0.15s)
        fix_test.go:42: no refactorings were applied
2022-12-12 16:16 linux-amd64-longtest tools@18f76ecd go@27301e82 x/tools/gopls/internal/regtest/misc.TestFillStruct (log) 
serve.go:434: debug server listening at http://localhost:40681
serve.go:434: debug server listening at http://localhost:46153
2022/12/12 16:20:46 template: :9:109: executing "body" at <.Session.ID>: can't evaluate field Session in type *cache.View
server.go:3217: http: superfluous response.WriteHeader call from golang.org/x/tools/gopls/internal/lsp/debug.render.func1 (serve.go:666)
#### Start Gopls Test Logs for "TestFillStruct/experimental"
[Trace - 16:21:10.178 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/workdir/tmp/gopls-regtest-1487279933/TestFillStruct/experimental/gopath","GOPROXY":"file:///workdir/tmp/gopls-regtest-1487279933/TestFillStruct/experimental/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///workdir/tmp/gopls-regtest-1487279933/TestFillStruct/experimental/work","name":"work"}]}


[Trace - 16:21:10.178 PM] Received response 'initialize - (1)' in 0ms.
...
Params: {"command":"gopls.apply_fix","arguments":[{"Fix":"fill_struct","URI":"file:///workdir/tmp/gopls-regtest-1487279933/TestFillStruct/experimental/work/main.go","Range":{"start":{"line":8,"character":5},"end":{"line":8,"character":11}}}]}


[Error - Received] 16:21:10.278 PM #3 start: pos 98 is not in range for file [215:321)


#### End Gopls Test Logs for "TestFillStruct/experimental"
--- FAIL: TestFillStruct (0.43s)
    --- FAIL: TestFillStruct/experimental (0.12s)
        fix_test.go:42: no refactorings were applied
2022-12-13 13:03 linux-amd64-longtest tools@d72a64a9 go@b16e94d1 x/tools/gopls/internal/regtest/misc.TestFillStruct (log) 
serve.go:434: debug server listening at http://localhost:40355
serve.go:434: debug server listening at http://localhost:46065
2022/12/13 13:08:19 template: :9:109: executing "body" at <.Session.ID>: can't evaluate field Session in type *cache.View
server.go:3217: http: superfluous response.WriteHeader call from golang.org/x/tools/gopls/internal/lsp/debug.render.func1 (serve.go:666)
#### Start Gopls Test Logs for "TestFillStruct/experimental"
[Trace - 13:08:43.853 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/workdir/tmp/gopls-regtest-2879036737/TestFillStruct/experimental/gopath","GOPROXY":"file:///workdir/tmp/gopls-regtest-2879036737/TestFillStruct/experimental/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///workdir/tmp/gopls-regtest-2879036737/TestFillStruct/experimental/work","name":"work"}]}


[Trace - 13:08:43.853 PM] Received response 'initialize - (1)' in 0ms.
...
Params: {"command":"gopls.apply_fix","arguments":[{"Fix":"fill_struct","URI":"file:///workdir/tmp/gopls-regtest-2879036737/TestFillStruct/experimental/work/main.go","Range":{"start":{"line":8,"character":5},"end":{"line":8,"character":11}}}]}


[Error - Received] 13:08:43.964 PM #3 start: pos 98 is not in range for file [215:321)


#### End Gopls Test Logs for "TestFillStruct/experimental"
--- FAIL: TestFillStruct (0.41s)
    --- FAIL: TestFillStruct/experimental (0.14s)
        fix_test.go:42: no refactorings were applied
2022-12-13 14:19 linux-386-longtest tools@95c9dce0 go@5ba98b97 x/tools/gopls/internal/regtest/misc.TestFillStruct (log) 
serve.go:434: debug server listening at http://localhost:33399
serve.go:434: debug server listening at http://localhost:42595
2022/12/13 17:06:56 template: :9:109: executing "body" at <.Session.ID>: can't evaluate field Session in type *cache.View
server.go:3217: http: superfluous response.WriteHeader call from golang.org/x/tools/gopls/internal/lsp/debug.render.func1 (serve.go:666)
#### Start Gopls Test Logs for "TestFillStruct/experimental"
[Trace - 17:07:21.458 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/workdir/tmp/gopls-regtest-2317933440/TestFillStruct/experimental/gopath","GOPROXY":"file:///workdir/tmp/gopls-regtest-2317933440/TestFillStruct/experimental/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///workdir/tmp/gopls-regtest-2317933440/TestFillStruct/experimental/work","name":"work"}]}


[Trace - 17:07:21.458 PM] Received response 'initialize - (1)' in 0ms.
...


[Trace - 17:07:21.565 PM] Received notification 'textDocument/publishDiagnostics'.
Params: {"uri":"file:///workdir/tmp/gopls-regtest-2317933440/TestFillStruct/experimental/work/main.go","version":1,"diagnostics":[]}


#### End Gopls Test Logs for "TestFillStruct/experimental"
--- FAIL: TestFillStruct (0.42s)
    --- FAIL: TestFillStruct/experimental (0.13s)
        fix_test.go:42: no refactorings were applied

— watchflakes

@findleyr
Copy link
Contributor

Fixed by https://go.dev/cl/456977

@golang golang locked and limited conversation to collaborators Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@gopherbot @findleyr