Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/doc: TestGenerated failures #57368

Closed
gopherbot opened this issue Dec 17, 2022 · 9 comments
Closed

x/tools/gopls/doc: TestGenerated failures #57368

gopherbot opened this issue Dec 17, 2022 · 9 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.14.0

Comments

@gopherbot
Copy link

gopherbot commented Dec 17, 2022 •
edited by bcmills 

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/doc" && test == "TestGenerated" && date < "2023-02-01"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestGenerated (7.25s)
    generate_test.go:21: packages.Load: err: exit status 1: stderr: go: error obtaining buildID for go tool compile: fork/exec C:\workdir\go\pkg\tool\windows_arm64\compile.exe: The paging file is too small for this operation to complete.

— watchflakes
@gopherbot gopherbot added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Dec 17, 2022
@gopherbot gopherbot added this to the Unreleased milestone Dec 17, 2022
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/doc" && test == "TestGenerated"
2022-12-07 15:31 windows-arm64-11 tools@09fb680d go@dc04f3ba x/tools/gopls/doc.TestGenerated (log) 
--- FAIL: TestGenerated (7.25s)
    generate_test.go:21: packages.Load: err: exit status 1: stderr: go: error obtaining buildID for go tool compile: fork/exec C:\workdir\go\pkg\tool\windows_arm64\compile.exe: The paging file is too small for this operation to complete.

— watchflakes

@findleyr
Copy link
Contributor

CC @bcmills -- any idea what this is?

@hyangah hyangah modified the milestones: Unreleased, gopls/v0.12.0 Dec 22, 2022
@bcmills
Copy link
Contributor

bcmills commented Feb 1, 2023

Duplicate of #51019

@bcmills bcmills marked this as a duplicate of #51019 Feb 1, 2023
@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Feb 1, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/doc" && test == "TestGenerated"
2023-05-20 03:32 plan9-arm tools@d4e66bd9 go@10532fdb x/tools/gopls/doc.TestGenerated (log) 
--- FAIL: TestGenerated (0.08s)
    generate_test.go:14: go tool not available: exit status: 'go 17255: 1'
2023-05-20 03:32 plan9-arm tools@d4e66bd9 go@9c447b7c x/tools/gopls/doc.TestGenerated (log) 
--- FAIL: TestGenerated (0.21s)
    generate_test.go:14: go tool not available: /boot/workdir/go/bin/go tool -n compile: exit status: 'go 17234: 1'
        go: open /boot/workdir/gopath/src/golang.org/x/tools/gopls/go.mod: '/boot/workdir/gopath/src/golang.org/x/tools/gopls/go.mod' exclusive lock

— watchflakes

@gopherbot gopherbot reopened this May 20, 2023
@findleyr
Copy link
Contributor

go: open /boot/workdir/gopath/src/golang.org/x/tools/gopls/go.mod: '/boot/workdir/gopath/src/golang.org/x/tools/gopls/go.mod' exclusive lock

This test only needs to run on one builder. I'll skip on plan9, but not urgently.

@findleyr findleyr modified the milestones: gopls/v0.12.0, gopls/v0.13.0 May 21, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/doc" && test == "TestGenerated"
2023-07-10 17:03 netbsd-arm-bsiegert tools@538a6e9e go@5fa6923b x/tools/gopls/doc.TestGenerated (log) 
--- FAIL: TestGenerated (97.06s)
    generate_test.go:23: signal: segmentation fault (core dumped)

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/doc" && test == "TestGenerated"
2023-08-21 13:22 plan9-arm tools@ff7f2b9c go@50f2b7b7 x/tools/gopls/doc.TestGenerated (log) 
panic: test timed out after 30m0s
running tests:
	TestGenerated (30m0s)

golang.org/x/tools/internal/gocommand.runCmdContext({0x4e6628, 0x7094a0}, 0x93ce000)
	/boot/workdir/gopath/src/golang.org/x/tools/internal/gocommand/invoke.go:376 +0x468
golang.org/x/tools/internal/gocommand.(*Invocation).run(0x90def28, {0x4e6628, 0x7094a0}, {0x4e4738, 0x12ef5278}, {0x4e4738, 0x12ef5290})
	/boot/workdir/gopath/src/golang.org/x/tools/internal/gocommand/invoke.go:267 +0xf94
golang.org/x/tools/internal/gocommand.(*Invocation).runWithFriendlyError(0x90def28, {0x4e6628, 0x7094a0}, {0x4e4738, 0x12ef5278}, {0x4e4738, 0x12ef5290})
	/boot/workdir/gopath/src/golang.org/x/tools/internal/gocommand/invoke.go:176 +0x4c
...
	/boot/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/command/commandmeta/meta.go:50 +0x94
golang.org/x/tools/gopls/doc.loadCommands(0x94b6fc0)
	/boot/workdir/gopath/src/golang.org/x/tools/gopls/doc/generate.go:412 +0x14
golang.org/x/tools/gopls/doc.loadAPI()
	/boot/workdir/gopath/src/golang.org/x/tools/gopls/doc/generate.go:112 +0x100
golang.org/x/tools/gopls/doc.doMain(0x0)
	/boot/workdir/gopath/src/golang.org/x/tools/gopls/doc/generate.go:51 +0x18
golang.org/x/tools/gopls/doc.TestGenerated(0x90d21e0)
	/boot/workdir/gopath/src/golang.org/x/tools/gopls/doc/generate_test.go:21 +0x60
testing.tRunner(0x90d21e0, 0x46fc48)

— watchflakes

@gopherbot
Copy link
Author

Change https://go.dev/cl/521122 mentions this issue: gopls/doc: don't run TestGenerated on plan9

@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Aug 21, 2023
@bcmills
Copy link
Contributor

bcmills commented Aug 21, 2023

These new failures aren't related to the original failure mode; they should go to #49338 or be filed as new issues, and would by default if #57632 were addressed.

I've updated the pattern to stop watchflakes from reopening it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Done
Milestone
gopls/v0.14.0
Development

No branches or pull requests
4 participants
@hyangah @bcmills @gopherbot @findleyr