Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/packages: TestContainsOverlayXTest failures #57365

Closed
gopherbot opened this issue Dec 17, 2022 · 2 comments
Closed

x/tools/go/packages: TestContainsOverlayXTest failures #57365

gopherbot opened this issue Dec 17, 2022 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "golang.org/x/tools/go/packages" && test == "TestContainsOverlayXTest"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestContainsOverlayXTest (0.00s)
    --- FAIL: TestContainsOverlayXTest/Modules (6.91s)
        overlay_test.go:711: wrong import graph: got <<* command-line-arguments_test [command-line-arguments.test]
              golang.org/fake/b
              golang.org/fake/c
              command-line-arguments_test [command-line-arguments.test] -> golang.org/fake/b
              golang.org/fake/b -> golang.org/fake/c
            >>, want <<  golang.org/fake/b
            * golang.org/fake/b_test [golang.org/fake/b.test]
              golang.org/fake/c
              golang.org/fake/b -> golang.org/fake/c
              golang.org/fake/b_test [golang.org/fake/b.test] -> golang.org/fake/b
            >>

— watchflakes
@gopherbot gopherbot added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository. labels Dec 17, 2022
@gopherbot gopherbot added this to the Unreleased milestone Dec 17, 2022
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/go/packages" && test == "TestContainsOverlayXTest"
2022-12-07 15:31 windows-arm64-11 tools@09fb680d go@dc04f3ba x/tools/go/packages.TestContainsOverlayXTest (log) 
--- FAIL: TestContainsOverlayXTest (0.00s)
    --- FAIL: TestContainsOverlayXTest/Modules (6.91s)
        overlay_test.go:711: wrong import graph: got <<* command-line-arguments_test [command-line-arguments.test]
              golang.org/fake/b
              golang.org/fake/c
              command-line-arguments_test [command-line-arguments.test] -> golang.org/fake/b
              golang.org/fake/b -> golang.org/fake/c
            >>, want <<  golang.org/fake/b
            * golang.org/fake/b_test [golang.org/fake/b.test]
              golang.org/fake/c
              golang.org/fake/b -> golang.org/fake/c
              golang.org/fake/b_test [golang.org/fake/b.test] -> golang.org/fake/b
            >>

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Feb 1, 2023

Duplicate of #51019

@bcmills bcmills marked this as a duplicate of #51019 Feb 1, 2023
@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Feb 1, 2023
@golang golang locked and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bcmills @gopherbot