Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: TestDialCancel failures #57364

Closed
gopherbot opened this issue Dec 17, 2022 · 11 comments
Closed

net: TestDialCancel failures #57364

gopherbot opened this issue Dec 17, 2022 · 11 comments
Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.21

Comments

@gopherbot
Copy link

gopherbot commented Dec 17, 2022 •
edited by bcmills 

#!watchflakes
post <- pkg == "net" && test == "TestDialCancel" && date < "2023-05-18"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestDialCancel (0.01s)
    dial_test.go:792: dial error after 0 ticks (5 before cancel sent): dial tcp 198.18.0.254:1234: connect: no route to host

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 17, 2022
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net" && test == "TestDialCancel"
2022-12-06 19:52 linux-mips-rtrk go@03bf6f49 net.TestDialCancel (log) 
--- FAIL: TestDialCancel (0.01s)
    dial_test.go:792: dial error after 0 ticks (5 before cancel sent): dial tcp 198.18.0.254:1234: connect: no route to host
2022-12-08 18:29 linux-mipsle-rtrk go@7973b0e5 net.TestDialCancel (log) 
--- FAIL: TestDialCancel (0.01s)
    dial_test.go:792: dial error after 0 ticks (5 before cancel sent): dial tcp 198.18.0.254:1234: connect: no route to host

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net" && test == "TestDialCancel"
2022-12-22 18:03 linux-mips64-rtrk go@6c9b6618 net.TestDialCancel (log) 
--- FAIL: TestDialCancel (0.01s)
    dial_test.go:792: dial error after 0 ticks (5 before cancel sent): dial tcp 198.18.0.254:1234: connect: no route to host

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net" && test == "TestDialCancel"
2022-11-17 17:02 linux-mips64le-rtrk go@cafb49ac net.TestDialCancel (log) 
--- FAIL: TestDialCancel (0.01s)
    dial_test.go:792: dial error after 1 ticks (4 before cancel sent): dial tcp 198.18.0.254:1234: connect: no route to host
2022-11-18 00:16 linux-mipsle-rtrk go@a8f9d3f0 net.TestDialCancel (log) 
--- FAIL: TestDialCancel (0.01s)
    dial_test.go:792: dial error after 0 ticks (5 before cancel sent): dial tcp 198.18.0.254:1234: connect: no route to host
2022-12-08 23:06 linux-ppc64-sid-buildlet go@e738a2f1 net.TestDialCancel (log) 
--- FAIL: TestDialCancel (0.02s)
    dial_test.go:792: dial error after 1 ticks (4 before cancel sent): dial tcp 198.18.0.254:1234: connect: network is unreachable
2022-12-08 23:06 linux-ppc64le-buildlet go@e738a2f1 net.TestDialCancel (log) 
--- FAIL: TestDialCancel (0.00s)
    dial_test.go:792: dial error after 0 ticks (5 before cancel sent): dial tcp 198.18.0.254:1234: connect: network is unreachable
2022-12-08 23:06 linux-ppc64le-power9osu go@e738a2f1 net.TestDialCancel (log) 
--- FAIL: TestDialCancel (0.00s)
    dial_test.go:792: dial error after 0 ticks (5 before cancel sent): dial tcp 198.18.0.254:1234: connect: network is unreachable
2022-12-19 21:17 linux-mips-rtrk go@a5a47442 net.TestDialCancel (log) 
--- FAIL: TestDialCancel (0.01s)
    dial_test.go:792: dial error after 0 ticks (5 before cancel sent): dial tcp 198.18.0.254:1234: connect: no route to host
2022-12-29 23:36 linux-mips-rtrk go@db36eca3 net.TestDialCancel (log) 
--- FAIL: TestDialCancel (0.01s)
    dial_test.go:792: dial error after 1 ticks (4 before cancel sent): dial tcp 198.18.0.254:1234: connect: no route to host

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net" && test == "TestDialCancel"
2023-01-06 17:00 linux-mips64le-rtrk go@76ec9192 net.TestDialCancel (log) 
--- FAIL: TestDialCancel (0.01s)
    dial_test.go:792: dial error after 0 ticks (5 before cancel sent): dial tcp 198.18.0.254:1234: connect: no route to host
2023-01-11 22:26 linux-mips-rtrk go@18625d9b net.TestDialCancel (log) 
--- FAIL: TestDialCancel (0.01s)
    dial_test.go:792: dial error after 0 ticks (5 before cancel sent): dial tcp 198.18.0.254:1234: connect: no route to host

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net" && test == "TestDialCancel"
2023-01-24 01:02 linux-mipsle-rtrk go@7135710e net.TestDialCancel (log) 
--- FAIL: TestDialCancel (0.01s)
    dial_test.go:792: dial error after 0 ticks (5 before cancel sent): dial tcp 198.18.0.254:1234: connect: no route to host
2023-01-24 22:55 linux-mips64le-rtrk go@a37672bb net.TestDialCancel (log) 
--- FAIL: TestDialCancel (0.01s)
    dial_test.go:792: dial error after 0 ticks (5 before cancel sent): dial tcp 198.18.0.254:1234: connect: no route to host

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net" && test == "TestDialCancel"
2023-01-26 10:15 linux-mips64-rtrk go@4df10fba net.TestDialCancel (log) 
--- FAIL: TestDialCancel (0.01s)
    dial_test.go:792: dial error after 0 ticks (5 before cancel sent): dial tcp 198.18.0.254:1234: connect: no route to host

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net" && test == "TestDialCancel"
2023-03-23 22:09 linux-ppc64-sid-buildlet go@e0c69587 net.TestDialCancel (log) 
--- FAIL: TestDialCancel (0.00s)
    dial_test.go:792: dial error after 0 ticks (5 before cancel sent): dial tcp 198.18.0.254:1234: connect: network is unreachable
2023/03/23 22:16:21 killing splice client after 5 second shutdown timeout
2023-03-23 22:09 linux-ppc64le-buildlet go@e0c69587 net.TestDialCancel (log) 
--- FAIL: TestDialCancel (0.00s)
    dial_test.go:792: dial error after 0 ticks (5 before cancel sent): dial tcp 198.18.0.254:1234: connect: network is unreachable
2023/03/23 22:16:51 killing splice client after 5 second shutdown timeout
2023-03-23 22:09 linux-ppc64le-power9osu go@e0c69587 net.TestDialCancel (log) 
--- FAIL: TestDialCancel (0.00s)
    dial_test.go:792: dial error after 0 ticks (5 before cancel sent): dial tcp 198.18.0.254:1234: connect: network is unreachable
2023/03/23 22:19:47 killing splice client after 5 second shutdown timeout

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net" && test == "TestDialCancel"
2023-04-11 13:17 linux-ppc64le-buildlet go@e78871ea net.TestDialCancel (log) 
--- FAIL: TestDialCancel (0.00s)
    dial_test.go:792: dial error after 0 ticks (5 before cancel sent): dial tcp 198.18.0.254:1234: connect: network is unreachable
2023/04/11 13:32:09 killing splice client after 5 second shutdown timeout
2023-05-16 23:34 plan9-arm go@6d1c507b net.TestDialCancel (log) 
--- FAIL: TestDialCancel (3.01s)
    dial_test.go:792: dial error after 4 ticks (1 before cancel sent): dial tcp 198.18.0.254:1234: write /net/tcp/clone: host unreachable

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented May 17, 2023

attn @ianlancetaylor @neild; see also #52579.

@bcmills bcmills added this to the Backlog milestone May 17, 2023
@ianlancetaylor
Copy link
Contributor

The test relies on packets sent to the private network address 198.18.0.254 should just be dropped. But in some cases the builders are reporting errors. We already ignore an error. I'll ignore some more.

@gopherbot
Copy link
Author

Change https://go.dev/cl/496037 mentions this issue: net: ignore more errors in TestDialCancel

@dmitshur dmitshur added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels May 17, 2023
@dmitshur dmitshur modified the milestones: Backlog, Go1.21 May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Status: Done
Milestone
Go1.21
Development

No branches or pull requests
4 participants
@dmitshur @ianlancetaylor @bcmills @gopherbot