-
Notifications
You must be signed in to change notification settings - Fork 18k
x/net/proxy: SOCKS5 proxy should allow empty password #57285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
cc @neild |
Change https://go.dev/cl/457155 mentions this issue: |
Change https://go.dev/cl/457355 mentions this issue: |
From the RFC https://www.rfc-editor.org/rfc/rfc1929 I interpret that username and password are always >0 <=255 |
It's only noted at graph, I missed it. But it's supported widely. 🥹 |
Also we can allow empty username. |
In my opinion, it is. But I'm afraid it's too aggressively |
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes, it reproduced
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
I use an empty-password socks5 URL, like:
socks5://username:@127.0.0.1
. The connection closed after server negotiation.What did you expect to see?
The connection should be established.
What did you see instead?
I found the problem code might be here:
go/src/net/http/socks_bundle.go
Line 448 in b16e94d
After read the RFC, I found there is no limitation to empty password string. And both
curl
andgit
is ok in my test.So I think it's a bug and should be fixed.
If it's ok, I will create a PR for that.
The text was updated successfully, but these errors were encountered: