Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gerrit: shows lit.dev warnings unlike other Gerrit servers #57280

Open
mvdan opened this issue Dec 13, 2022 · 4 comments
Open

gerrit: shows lit.dev warnings unlike other Gerrit servers #57280

mvdan opened this issue Dec 13, 2022 · 4 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@mvdan
Copy link
Member

mvdan commented Dec 13, 2022

If I navigate to https://go-review.googlesource.com/dashboard/self while logged in, I see a few warnings in the console:

Lit is in dev mode. Not recommended for production! See https://lit.dev/msg/dev-mode for more information. rv-reviewers.js:772:200
Multiple versions of Lit loaded. Loading multiple versions is not recommended. See https://lit.dev/msg/multiple-versions for more information. rv-reviewers.js:772:200

I do not see these two warnings on different Gerrit instances like https://review.gerrithub.io/dashboard/self, for example. It could be that the difference in version is to blame, as they each run different git versions, but I couldn't find any gerrit issue about it, so I don't think it's an upstream issue. Could it be that your Gerrit is running in developer or debug mode?

Please feel free to move this if it is indeed an upstream bug.

cc @golang/release
@mvdan mvdan added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 13, 2022
@mvdan mvdan added this to the Unreleased milestone Dec 13, 2022
@heschi
Copy link
Contributor

heschi commented Dec 13, 2022

Our Gerrit instance is operated by the Gerrit team at Google, so this isn't something we can fix ourselves. Do you think it's worth escalating?

@mvdan
Copy link
Member Author

mvdan commented Dec 13, 2022

Thanks, I wasn't aware. I do think it's worth bringing up to them, as it seems like an oversight.

@heschi
Copy link
Contributor

heschi commented Dec 13, 2022

OK, I'll see what they say.

@mvdan
Copy link
Member Author

mvdan commented Mar 4, 2024

I still see these warnings; @heschi did you get a reply from them, or is there an upstream Gerrit bug I can follow instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@mvdan @heschi