Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/vuln/vulncheck: support for generics #57221

Open
zpavlinovic opened this issue Dec 9, 2022 · 1 comment
Open

x/vuln/vulncheck: support for generics #57221

zpavlinovic opened this issue Dec 9, 2022 · 1 comment
Assignees
@zpavlinovic
Labels
vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Milestone
vuln/unplanned

Comments

@zpavlinovic
Copy link
Contributor

vulncheck currently supports generics by instantiating them using ssa.InstantiateGenerics. But what happens for entry points that are generics functions: they themselves are not instantiated. They should in principle be supported just as functions accepting interfaces arguments, but it could be that the underlying vta callgraph is not handling them properly.

Investigate and make a long-term decision.
@zpavlinovic zpavlinovic added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Dec 9, 2022
@zpavlinovic zpavlinovic added this to the vuln/unplanned milestone Dec 9, 2022
@zpavlinovic zpavlinovic self-assigned this Dec 9, 2022
@zpavlinovic
Copy link
Contributor Author

Entry points that are generics are not currently computed in the set of entry points. ssa.MethodValue returns nil for such methods and functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zpavlinovic zpavlinovic

Labels
vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Projects
None yet
Milestone
vuln/unplanned
Development

No branches or pull requests
1 participant
@zpavlinovic