Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os: TestLstat failure on Linux Aarch64 [1.19 backport] #57214

Closed
gopherbot opened this issue Dec 9, 2022 · 2 comments
Closed

os: TestLstat failure on Linux Aarch64 [1.19 backport] #57214

gopherbot opened this issue Dec 9, 2022 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.19.5

Comments

@gopherbot
Copy link

@ianlancetaylor requested issue #57210 to be considered for backport to the next 1.19 minor release.

@gopherbot Please open backport issues.

This is a bug in the test that will show up on systems for which /etc/group is a symlink. Since apparently such systems exist, we should fix the bug in supported releases.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Dec 9, 2022
@gopherbot gopherbot mentioned this issue Dec 9, 2022
Closed
@gopherbot gopherbot added this to the Go1.19.5 milestone Dec 9, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/456560 mentions this issue: [release-branch.go1.19] os: skip size test in TestLstat if the file is a symlink

@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Dec 10, 2022
@thanm thanm added the CherryPickApproved Used during the release process for point releases label Dec 14, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Dec 14, 2022
@gopherbot
Copy link
Author

Closed by merging 45ba8ba to release-branch.go1.19.

gopherbot pushed a commit that referenced this issue Dec 14, 2022
@ianlancetaylor @gopherbot
[release-branch.go1.19] os: skip size test in TestLstat if the file i…
45ba8ba 
…s a symlink

Tested by temporarily changing sysdir to use a directory where
the expected files were all symlinks. We should consider using
a different approach that doesn't rely on sysdir, but for now
do a minimal fix.

For #57210
Fixes #57214

Change-Id: Ifb1becef03e014ceb48290ce13527b3e103c0e07
Reviewed-on: https://go-review.googlesource.com/c/go/+/456557
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 9b8750f)
Reviewed-on: https://go-review.googlesource.com/c/go/+/456560
Reviewed-by: Austin Clements <austin@google.com>
@golang golang locked and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.19.5
Development

No branches or pull requests
3 participants
@dmitshur @gopherbot @thanm