Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/safefilepath: TestFromFS failing on Plan 9 #57142

Closed
0intro opened this issue Dec 7, 2022 · 1 comment
Closed

internal/safefilepath: TestFromFS failing on Plan 9 #57142

0intro opened this issue Dec 7, 2022 · 1 comment
Assignees
@0intro
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Plan9
Milestone
Go1.20

Comments

@0intro
Copy link
Member

0intro commented Dec 7, 2022

CL 455716 added TestFromFS. This test is failing on Plan 9:

--- FAIL: TestFromFS (0.00s)
    path_test.go:75: FromFS("#c") = "#c", invalid path; want "" only if err != nil
    path_test.go:78: FromFS("#c") = "#c", invalid path; want ""
FAIL
FAIL	internal/safefilepath	0.031s

See https://build.golang.org/log/11e255836afa1fef269ce3fb6b831e9c914153c4

@millerresearch
@0intro 0intro added the OS-Plan9 label Dec 7, 2022
@0intro 0intro self-assigned this Dec 7, 2022
@gopherbot
Copy link

Change https://go.dev/cl/455835 mentions this issue: internal/safefilepath: fix TestFromFS on Plan 9

@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Dec 8, 2022
@dmitshur dmitshur added this to the Go1.20 milestone Dec 8, 2022
@golang golang locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@0intro 0intro

Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Plan9
Projects
None yet
Milestone
Go1.20
Development

No branches or pull requests
3 participants
@dmitshur @0intro @gopherbot