Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/exp/slog: does not build with 1.18 #57113

Closed
imle opened this issue Dec 6, 2022 · 3 comments
Closed

x/exp/slog: does not build with 1.18 #57113

imle opened this issue Dec 6, 2022 · 3 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@imle
Copy link

imle commented Dec 6, 2022

What version of Go are you using (go version)?

$ go version
go version go1.18.8 darwin/arm64

Does this issue reproduce with the latest release?

No, it works fine in 1.19

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="arm64"
GOBIN=""
GOCACHE="/Users/simle/Library/Caches/go-build"
GOENV="/Users/simle/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="arm64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/simle/Development/go/pkg/mod"
GONOPROXY="git.sqcorp.co,git.corp.squareup.com,github.com/squareup"
GONOSUMDB="git.sqcorp.co,git.corp.squareup.com,github.com/squareup"
GOOS="darwin"
GOPATH="/Users/simle/Development/go"
GOPRIVATE="git.sqcorp.co,git.corp.squareup.com,github.com/squareup"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/opt/homebrew/Cellar/go@1.18/1.18.8/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/opt/homebrew/Cellar/go@1.18/1.18.8/libexec/pkg/tool/darwin_arm64"
GOVCS=""
GOVERSION="go1.18.8"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/dj/8r2z_93n6h79603f18pcf1880000gn/T/go-build3340641431=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

I tried to import and use the package golang.org/x/exp/slog and ran into the issue of atomic.Int64 not being defined for 1.18.

What did you expect to see?

The go.mod file in the exp repo shows that it should work for 1.18.

What did you see instead?

Failure to build.
@imle imle mentioned this issue Dec 6, 2022
Closed
@imle imle changed the title affected/package: ep affected/package: exp Dec 6, 2022
@randall77
Copy link
Contributor

@jba

@prattmic prattmic changed the title affected/package: exp x/exp/slog: does not build with 1.18 Dec 6, 2022
@gopherbot gopherbot added this to the Unreleased milestone Dec 6, 2022
@prattmic prattmic added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 6, 2022
@jba
Copy link
Contributor

jba commented Dec 6, 2022

Since this package is an experimental implementation for something that will be in Go 1.2X, we don't feel that it needs to work on 1.18.

Is there a compelling reason you need it for 1.18?

@imle
Copy link
Author

imle commented Dec 6, 2022

No worries, wanted to try it out and am currently stuck with 1.18. I was making the assumption that it would work with that version based on the go.mod file and since it was just the one reference to atomic that was preventing it, that it might be worth enabling it by using atomic.Value instead.

@seankhliao seankhliao closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2022
@golang golang locked and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
6 participants
@prattmic @imle @randall77 @gopherbot @seankhliao @jba