Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: non-retpoline-compatible errors [1.19 backport] #57100

Closed
gopherbot opened this issue Dec 6, 2022 · 2 comments
Closed

cmd/compile: non-retpoline-compatible errors [1.19 backport] #57100

gopherbot opened this issue Dec 6, 2022 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Milestone
Go1.19.5

Comments

@gopherbot
Copy link

@randall77 requested issue #57097 to be considered for backport to the next 1.19 minor release.

@gopherbot please open a backport issue to 1.19.

This issue makes large switches fail to compile in -spectre=all or -spectre=ret mode.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Dec 6, 2022
@gopherbot gopherbot mentioned this issue Dec 6, 2022
Closed
@gopherbot gopherbot added this to the Go1.19.5 milestone Dec 6, 2022
@seankhliao seankhliao changed the title golang-compiler: non-retpoline-compatible errors [1.19 backport] cmd/compile: non-retpoline-compatible errors [1.19 backport] Dec 6, 2022
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Dec 6, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/455416 mentions this issue: [release-branch.go1.19] cmd/compile: turn off jump tables when spectre retpolines are on

@trippleflux trippleflux mentioned this issue Dec 7, 2022
Closed
@prattmic prattmic added the CherryPickApproved Used during the release process for point releases label Dec 7, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Dec 7, 2022
@gopherbot
Copy link
Author

Closed by merging 1565780 to release-branch.go1.19.

gopherbot pushed a commit that referenced this issue Dec 9, 2022
@randall77 @prattmic
[release-branch.go1.19] cmd/compile: turn off jump tables when spectr…
1565780 
…e retpolines are on

Fixes #57100

Change-Id: I6ab659abbca1ae0ac8710674d39aec116fab0baa
Reviewed-on: https://go-review.googlesource.com/c/go/+/455336
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Keith Randall <khr@golang.org>
(cherry picked from commit 1eb0465)
Reviewed-on: https://go-review.googlesource.com/c/go/+/455416
Reviewed-by: Michael Pratt <mpratt@google.com>
@golang golang locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Projects
None yet
Milestone
Go1.19.5
Development

No branches or pull requests
2 participants
@prattmic @gopherbot