New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build/internal/task: TestTweetRelease failures #57062
Labels
Milestone
Comments
gopherbot
added
the
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
label
Dec 2, 2022
Found new dashboard test flakes for:
2022-12-02 22:20 linux-amd64-longtest build@5b51d6fa go@7ab36153 x/build/internal/task.TestTweetRelease (log)
2022-12-02 22:20 windows-amd64-longtest build@5b51d6fa go@7ab36153 x/build/internal/task.TestTweetRelease (log)
|
dmitshur
added
NeedsFix
The path to resolution is known, but the work has not been done.
and removed
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
labels
Jun 7, 2023
Change https://go.dev/cl/504519 mentions this issue: |
Change https://go.dev/cl/504520 mentions this issue: |
Change https://go.dev/cl/504518 mentions this issue: |
gopherbot
pushed a commit
to golang/build
that referenced
this issue
Jun 22, 2023
Use task.WebsiteFile as values, not pointers, throughout x/build. It was already a value in some places, and it's a value in x/website where the original version of this type lives. It's simpler and fast enough for the needs of relui. This prepares for the next two CLs that drop network calls for fetching a random release archive by making their diff smaller. For golang/go#57062. Change-Id: Ib43a2e4cec6546c6cd7ec9de9d0ec6f8b17e0c3c Reviewed-on: https://go-review.googlesource.com/c/build/+/504518 Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
gopherbot
pushed a commit
to golang/build
that referenced
this issue
Jun 22, 2023
The tweet tasks are some of the earliest we've automated for relui. In fact, they were ready for use with the release process ahead of the rest of relui, so the only place to add them was the CLI-based x/build/cmd/releasebot command. Since release coordinators needed to provide all of the task inputs as a JSON object over CLI, at the time, it was easier to fetch information about the Go release artifacts that had been published for the very Go release being made by making a network call to the go.dev/dl/?mode=json API. By now, relui is complete and has all the steps interconnected without toil of invoking individual release steps manually, so it's easy for it to pass the release artifacts to the tweeting tasks directly, and avoid having to ask the website for the release it itself published (silly!). We can also drop the lightweight checking of bad version strings done in oneOrTwoGoVersions. Those typos can't happen now since relui picks the next version to release automatically. This CL does the re-wiring to drop the use of API from TweetRelease but makes almost no changes to the current comprehensive tweet tests, and they're still passing. The next change simplifies the tests to drop their temporary use of the API. For golang/go#57062. Change-Id: I60efc8c8c96152ff52c9fb5cc0f91262f0d8f494 Reviewed-on: https://go-review.googlesource.com/c/build/+/504519 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com> Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue created automatically to collect these failures.
Example (log):
— watchflakes
The text was updated successfully, but these errors were encountered: