New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: document GOROOT/bin/go PATH entry for go test
and go generate
#57050
Comments
Hi @bcmills, can I work on this? I assume I need to update the documentation in these files. https://github.com/golang/go/blob/master/src/cmd/go/internal/generate/generate.go Should I refer to this?
|
Change https://go.dev/cl/461683 mentions this issue: |
@gopherbot Please consider this as a backport to Go 1.20 and 1.19. This is a documentation-only fix to document a Go 1.19 feature added to |
Backport issue(s) opened: #60457 (for 1.19), #60458 (for 1.20), Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://go.dev/wiki/MinorReleases. |
Change https://go.dev/cl/499218 mentions this issue: |
Change https://go.dev/cl/499295 mentions this issue: |
…est and go generate For #57050. Fixes #60457. Change-Id: I46cac667ff78ac171c878f4366f8f01f58f1d27d GitHub-Last-Rev: 697c255 GitHub-Pull-Request: #57814 Reviewed-on: https://go-review.googlesource.com/c/go/+/461683 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Bryan Mills <bcmills@google.com> (cherry picked from commit 93d9035) Reviewed-on: https://go-review.googlesource.com/c/go/+/499295 Run-TryBot: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
…est and go generate For #57050. Fixes #60458. Change-Id: I46cac667ff78ac171c878f4366f8f01f58f1d27d GitHub-Last-Rev: 697c255 GitHub-Pull-Request: #57814 Reviewed-on: https://go-review.googlesource.com/c/go/+/461683 TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Bryan Mills <bcmills@google.com> (cherry picked from commit 93d9035) Reviewed-on: https://go-review.googlesource.com/c/go/+/499218 Run-TryBot: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
CL 404134 (in Go 1.19) changed
go test
andgo generate
to always placeGOROOT/bin
at the beginning of thePATH
list for the subprocess.I added a release note for it (in CL 409176), but forget to update the documentation for the actual commands. It should be mentioned explicitly in the documentation for
go test
andgo generate
.The text was updated successfully, but these errors were encountered: