Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gopherbot: pick next minor release milestone, not "latest" open one, in setMinorMilestones #57031

Closed
dmitshur opened this issue Dec 1, 2022 · 1 comment
Closed

x/build/cmd/gopherbot: pick next minor release milestone, not "latest" open one, in setMinorMilestones #57031

dmitshur opened this issue Dec 1, 2022 · 1 comment
Assignees
@dmitshur
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Dec 1, 2022

It's useful to be able to create a future Go version milestone ahead of time to hold an issue that is known not to need attention for some time, and we do this ocassionally (e.g., #41152, #56836, etc.).

gopherbot's setMinorMilestones task gets confused when this happens for minor release milestones, and starts to assign backport issues to the latest open minor milestone, rather than the upcoming one:

image

We should change it to pick the upcoming minor release by default. We have current Go version information available, making it easier to do this than in 2018 when this task was originally added. I'll send a CL.

CC @golang/release, @rsc.
@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Dec 1, 2022
@dmitshur dmitshur added this to the Unreleased milestone Dec 1, 2022
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Dec 1, 2022
@gopherbot
Copy link

Change https://go.dev/cl/454495 mentions this issue: cmd/gopherbot: apply minor release milestones more precisely

@dmitshur dmitshur self-assigned this Dec 6, 2022
@golang golang locked and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dmitshur dmitshur

Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot