Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: failure in TestRaiseException on windows-amd64-2012 [1.19 backport] #56983

Closed
gopherbot opened this issue Nov 29, 2022 · 2 comments
Closed

runtime: failure in TestRaiseException on windows-amd64-2012 [1.19 backport] #56983

gopherbot opened this issue Nov 29, 2022 · 2 comments
Assignees
@thanm
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Milestone
Go1.19.5

Comments

@gopherbot
Copy link

@thanm requested issue #49681 to be considered for backport to the next 1.19 minor release.

@gopherbot please consider for 1.19 backport
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Nov 29, 2022
@gopherbot gopherbot mentioned this issue Nov 29, 2022
Open
@thanm thanm self-assigned this Nov 29, 2022
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Nov 29, 2022
@gopherbot gopherbot added this to the Go1.19.5 milestone Nov 29, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/454035 mentions this issue: [release-branch.go1.19] testing: skip flaky TestRaiseException on windows-amd64-2012-*

@toothrot toothrot added the CherryPickApproved Used during the release process for point releases label Nov 30, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Nov 30, 2022
gopherbot pushed a commit that referenced this issue Nov 30, 2022
@thanm
[release-branch.go1.19] testing: skip flaky TestRaiseException on win…
9f44333 
…dows-amd64-2012-*

Modify skip rule for TestRaiseException to trigger on both the base
builder (windows-amd64-2012) and the oldcc legacy builder
(windows-amd64-2012-oldcc) used for 1.18/1.19 testing.

Updates #56983.

Change-Id: I132f9ddd102666b68ad04cc661fdcc2cd841051a
Reviewed-on: https://go-review.googlesource.com/c/go/+/451294
Auto-Submit: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Than McIntosh <thanm@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
(cherry picked from commit f0331c5)
Reviewed-on: https://go-review.googlesource.com/c/go/+/454035
Reviewed-by: Cherry Mui <cherryyz@google.com>
TryBot-Bypass: Than McIntosh <thanm@google.com>
@gopherbot
Copy link
Author

Closed by merging 9f44333 to release-branch.go1.19.

andrew-d pushed a commit to tailscale/go that referenced this issue Dec 7, 2022
@thanm @andrew-d
[release-branch.go1.19] testing: skip flaky TestRaiseException on win…
9e615f2 
…dows-amd64-2012-*

Modify skip rule for TestRaiseException to trigger on both the base
builder (windows-amd64-2012) and the oldcc legacy builder
(windows-amd64-2012-oldcc) used for 1.18/1.19 testing.

Updates golang#56983.

Change-Id: I132f9ddd102666b68ad04cc661fdcc2cd841051a
Reviewed-on: https://go-review.googlesource.com/c/go/+/451294
Auto-Submit: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Than McIntosh <thanm@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
(cherry picked from commit f0331c5)
Reviewed-on: https://go-review.googlesource.com/c/go/+/454035
Reviewed-by: Cherry Mui <cherryyz@google.com>
TryBot-Bypass: Than McIntosh <thanm@google.com>
@golang golang locked and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@thanm thanm

Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Projects
None yet
Milestone
Go1.19.5
Development

No branches or pull requests
3 participants
@toothrot @gopherbot @thanm