Relevant: #57003

CC @golang/windows

If #57003 #57004 are accepted, this issue should be closed directly. I've migrated to Windows Server 2022 now, but there's still a lot of Windows 7 in my company, I am really worrying about their assets. XD

I read code at https://go.dev/play/p/LjfMdT6mTHZ and the error can be returned on line 44 or 48. It would help to write repro code in a way that is always obvious where the problem is.

I suspect this code might fail for many different reasons other than been run on Windows 7. But I am not Windows security expert. So I could be wrong.

@kmahyyg you will have better chance to get help with this, if you post your question somewhere where Windows developers are. Perhaps https://stackoverflow.com ?

Alex

@alexbrainman

and the error can be returned on line 44 or 48.

Just add a line number in error message when print out. Now it's L44. Check pointer in memory using debugger, you'll see more.

I mostly wrote these code using Windows native CPP, they are always working in CPP, But I don't know why these functions in golang library are written in this way.

... I mostly wrote these code using Windows native CPP, they are always working in CPP, But I don't know why these functions in golang library are written in this way.

If you can reproduce this problem with C program, you can just compare your C and Go programs and see what is different. You can remove bits from your programs until it is obvious where the problem is.

Alex

The problem here is why your library implements the function in this way which lead to fault. Not my code. I just give an example and say I met a situation that something went wrong. And trying to tell u there's an issue.

Ouch, and also, Windows 7 reaches its EOL in a few days. Let's just throw it away. (even a lot of Windows 7 machines is running in Production)

@alexbrainman Token(^uintptr(4 - 1)) makes me really confused, though.

https://cs.opensource.google/go/x/sys/+/refs/tags/v0.3.0:windows/security_windows.go;l=668

//sys	OpenProcessToken(process Handle, access uint32, token *Token) (err error) = advapi32.OpenProcessToken

type Token Handle

// OpenCurrentProcessToken opens an access token associated with current
// process with TOKEN_QUERY access. It is a real token that needs to be closed.
//
// Deprecated: Explicitly call OpenProcessToken(CurrentProcess(), ...)
// with the desired access instead, or use GetCurrentProcessToken for a
// TOKEN_QUERY token.
func OpenCurrentProcessToken() (Token, error) {
	var token Token
	err := OpenProcessToken(CurrentProcess(), TOKEN_QUERY, &token)
	return token, err
}

// GetCurrentProcessToken returns the access token associated with
// the current process. It is a pseudo token that does not need
// to be closed.
func GetCurrentProcessToken() Token {
	return Token(^uintptr(4 - 1))
}