Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug/elf: add (*File).DynValue #56892

Closed
florinpapa opened this issue Nov 21, 2022 · 9 comments
Closed

debug/elf: add (*File).DynValue #56892

florinpapa opened this issue Nov 21, 2022 · 9 comments

Comments

@florinpapa
Copy link
Contributor

DynString currently offers functionality to retrieve only string-valued .dynamic entries (e.g. entries described here as "string table offset of..."). However, many of them do not correspond to entries in the string table, and it would be useful to be able to extract those values too (e.g. to determine whether a binary is a PIE via the DF_1_PIE flag).

@gopherbot gopherbot added this to the Proposal milestone Nov 21, 2022
@gopherbot
Copy link

Change https://go.dev/cl/452617 mentions this issue: debug/elf: retrieve values for dynamic section tags

@seankhliao
Copy link
Member

what does the proposed API change look like?

@ianlancetaylor
Copy link
Contributor

From the CL, it appears that the proposal is

// DynValue returns the values listed for the given tag in the file's dynamic
// section.
func (f *File) DynValue(tag DynTag) ([]uint64, error)

@florinpapa
Copy link
Contributor Author

Right, thank you. I missed the message from Nov 22nd.

@rsc
Copy link
Contributor

rsc commented Feb 9, 2023

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

@rsc rsc changed the title proposal: debug/elf: add functionality for retrieving contents of DynTags that are not string values proposal: debug/elf: add (*File).DynValue Feb 22, 2023
@rsc
Copy link
Contributor

rsc commented Feb 22, 2023

This seems completely reasonable and I don't see any objections.

@rsc
Copy link
Contributor

rsc commented Feb 22, 2023

Based on the discussion above, this proposal seems like a likely accept.
— rsc for the proposal review group

@rsc
Copy link
Contributor

rsc commented Mar 1, 2023

No change in consensus, so accepted. 🎉
This issue now tracks the work of implementing the proposal.
— rsc for the proposal review group

@rsc rsc changed the title proposal: debug/elf: add (*File).DynValue debug/elf: add (*File).DynValue Mar 1, 2023
@rsc rsc modified the milestones: Proposal, Backlog Mar 1, 2023
@gopherbot
Copy link

Change https://go.dev/cl/499616 mentions this issue: doc/go1.21: mention debug/elf changes

gopherbot pushed a commit that referenced this issue May 31, 2023
For #55107
For #56887
For #56892

Change-Id: Ibcca34c931ed3595d877c4573bba221dec66bb5a
Reviewed-on: https://go-review.googlesource.com/c/go/+/499616
Reviewed-by: Eli Bendersky <eliben@google.com>
TryBot-Bypass: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
@dmitshur dmitshur modified the milestones: Backlog, Go1.21 Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants