Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd: vendor x/tools to 3b9d20c52192 [freeze exception] #56890

Closed
timothy-king opened this issue Nov 21, 2022 · 2 comments
Closed

cmd: vendor x/tools to 3b9d20c52192 [freeze exception] #56890

timothy-king opened this issue Nov 21, 2022 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.20

Comments

@timothy-king
Copy link
Contributor

https://github.com/orgs/golang/teams/release, may we have a freeze exception to land CL 452615. This fixed https://go.dev/issue/16520. It is going to miss the freeze by about an hour. This lands CL 452155 which was reviewed and made it to x/tools before the freeze. We are trying to prevent 452155 from being vendored with x/tools later in the middle of the freeze cycle.
@heschi
Copy link
Contributor

heschi commented Nov 21, 2022

Doesn't need an exception, or really doesn't need to be done at all: we're going to vendor in dependencies soon as part of #36905 anyway. But since you've already got the CL ready feel free to submit it.

@timothy-king
Copy link
Contributor Author

Thank you.

@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 21, 2022
@dmitshur dmitshur added this to the Go1.20 milestone Nov 21, 2022
@golang golang locked and limited conversation to collaborators Nov 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.20
Development

No branches or pull requests
4 participants
@timothy-king @dmitshur @gopherbot @heschi