Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/x509: add String() for KeyUsage, ExtKeyUsage #56866

Open
izolight opened this issue Nov 21, 2022 · 7 comments · May be fixed by #56005
Open

crypto/x509: add String() for KeyUsage, ExtKeyUsage #56866

izolight opened this issue Nov 21, 2022 · 7 comments · May be fixed by #56005
Labels
Proposal Proposal-Accepted Proposal-Crypto Proposal related to crypto packages or other security issues
Milestone
Backlog

Comments

@izolight
Copy link
Contributor

Some fields of x509.Certificate, like SignatureAlgorithm or PublicKeyAlgorightm already have a String() method. This proposal adds them to the KeyUsage and ExtKeyUsage types, which is mainly useful when printing/logging the certificate.
@gopherbot gopherbot added this to the Proposal milestone Nov 21, 2022
@izolight izolight linked a pull request Nov 21, 2022 that will close this issue
Open
@gopherbot
Copy link

Change https://go.dev/cl/437875 mentions this issue: crypto/x509: add String() for KeyUsage, ExtKeyUsage

@ianlancetaylor ianlancetaylor added the Proposal-Crypto Proposal related to crypto packages or other security issues label Nov 30, 2022
@rsc
Copy link
Contributor

rsc commented Nov 30, 2022

/cc @rolandshoemaker @golang/security

@rsc
Copy link
Contributor

rsc commented Nov 30, 2022

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

@rolandshoemaker
Copy link
Member

No objection, seems like a reasonable addition.

@rsc
Copy link
Contributor

rsc commented Dec 7, 2022

Based on the discussion above, this proposal seems like a likely accept.
— rsc for the proposal review group

@rsc
Copy link
Contributor

rsc commented Dec 14, 2022

No change in consensus, so accepted. 🎉
This issue now tracks the work of implementing the proposal.
— rsc for the proposal review group

@rsc rsc changed the title proposal: crypto/x509: add String() for KeyUsage, ExtKeyUsage crypto/x509: add String() for KeyUsage, ExtKeyUsage Dec 14, 2022
@rsc rsc modified the milestones: Proposal, Backlog Dec 14, 2022
@gopherbot
Copy link

Change https://go.dev/cl/571035 mentions this issue: crypto/x509: generate String methods for {KeyUsage, ExtKeyUsage}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Proposal Proposal-Accepted Proposal-Crypto Proposal related to crypto packages or other security issues
Projects
Proposals
Status: Accepted
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

crypto/x509: add String() for KeyUsage, ExtKeyUsage izolight/go
6 participants
@rsc @izolight @ianlancetaylor @rolandshoemaker @gopherbot and others