Skip to content

x/vuln/internal: TestAbsRelShorter consistently failing on darwin-amd64-10_14 and darwin-amd64-10_15 builders since 2022-11-08 #56838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bcmills opened this issue Nov 18, 2022 · 1 comment
Closed

x/vuln/internal: TestAbsRelShorter consistently failing on darwin-amd64-10_14 and darwin-amd64-10_15 builders since 2022-11-08 #56838

bcmills opened this issue Nov 18, 2022 · 1 comment
Assignees
@zpavlinovic
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Milestone
vuln/unplanned

Comments

@bcmills
Copy link
Contributor

bcmills commented Nov 18, 2022

https://build.golang.org/log/e76e43ce47333d5decda51752604677b470c7b15:

--- FAIL: TestAbsRelShorter (0.00s)
    filepath_test.go:36: want /var/folders/kh/5zzynz152r94t18yzstnrwx80000gn/T/workdir-host-darwin-amd64-10_15/tmp/filepath_test.gp3808731350; got ../../../../../../tmp/filepath_test.gp3808731350
FAIL
FAIL	golang.org/x/vuln/internal	0.216s

These failures seem to have started around CL 447855 (attn @zpavlinovic @hyangah)
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 18, 2022
@gopherbot gopherbot added the vulncheck or vulndb Issues for the x/vuln or x/vulndb repo label Nov 18, 2022
@gopherbot gopherbot modified the milestones: Unreleased, vuln/unplanned Nov 18, 2022
@zpavlinovic zpavlinovic self-assigned this Nov 18, 2022
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/452655 mentions this issue: internal: remove problematic test case

softdev050 added a commit to softdev050/Golangvuln that referenced this issue Apr 5, 2023
@softdev050
internal: remove problematic test case
e5292e4 
A test case for AbsRelPath does not work on all platforms and does not
bring much value. We delete it then.

Fixes golang/go#56838

Change-Id: Ia8b24e36e909d2bd3f601e9cd5ec3aa0ffe51eb1
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/452655
Run-TryBot: Zvonimir Pavlinovic <zpavlinovic@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
sayjun0505 added a commit to sayjun0505/Golangvuln that referenced this issue Apr 8, 2023
@sayjun0505
internal: remove problematic test case
49d8cda 
A test case for AbsRelPath does not work on all platforms and does not
bring much value. We delete it then.

Fixes golang/go#56838

Change-Id: Ia8b24e36e909d2bd3f601e9cd5ec3aa0ffe51eb1
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/452655
Run-TryBot: Zvonimir Pavlinovic <zpavlinovic@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
stanislavkononiuk added a commit to stanislavkononiuk/Golangvuln that referenced this issue Jun 26, 2023
@stanislavkononiuk
internal: remove problematic test case
2c68a92 
A test case for AbsRelPath does not work on all platforms and does not
bring much value. We delete it then.

Fixes golang/go#56838

Change-Id: Ia8b24e36e909d2bd3f601e9cd5ec3aa0ffe51eb1
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/452655
Run-TryBot: Zvonimir Pavlinovic <zpavlinovic@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Jonathan Amsterdam <jba@google.com>
@golang golang locked and limited conversation to collaborators Nov 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@zpavlinovic zpavlinovic

Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo
Projects
None yet
Milestone
vuln/unplanned
Development

No branches or pull requests
3 participants
@zpavlinovic @bcmills @gopherbot