Skip to content

os/exec: TestFindExecutableVsNoexec failures with ETXTBSY #56811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Nov 17, 2022 · 5 comments
Closed

os/exec: TestFindExecutableVsNoexec failures with ETXTBSY #56811

gopherbot opened this issue Nov 17, 2022 · 5 comments
Assignees
@bcmills
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.20

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Nov 17, 2022 •
edited by bcmills
Loading 

#!watchflakes
post <- pkg == "os/exec" && `text file busy`

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestFindExecutableVsNoexec (0.00s)
    lp_linux_test.go:52: exec: got fork/exec /workdir/tmp/TestFindExecutableVsNoexec867970659/001/program: text file busy, want nil

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 17, 2022
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "os/exec" && test == "TestFindExecutableVsNoexec"
2022-11-17 03:47 linux-amd64-longtest-race go@fee0ab8b os/exec.TestFindExecutableVsNoexec (log) 
--- FAIL: TestFindExecutableVsNoexec (0.00s)
    lp_linux_test.go:52: exec: got fork/exec /workdir/tmp/TestFindExecutableVsNoexec867970659/001/program: text file busy, want nil

— watchflakes

@bcmills bcmills changed the title os/exec: TestFindExecutableVsNoexec failures os/exec: TestFindExecutableVsNoexec failures with ETXTBSY Nov 17, 2022
@bcmills bcmills added this to the Backlog milestone Nov 17, 2022
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "os/exec" && `text file busy`
2022-12-01 16:39 linux-amd64-nounified go@15e705ea os/exec.TestFindExecutableVsNoexec (log) 
--- FAIL: TestFindExecutableVsNoexec (0.02s)
    lp_linux_test.go:52: exec: got fork/exec /workdir/tmp/TestFindExecutableVsNoexec389199221/001/program: text file busy, want nil

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Dec 5, 2022

This is probably a case of #22315.

@bcmills bcmills self-assigned this Dec 15, 2022
@bcmills bcmills modified the milestones: Backlog, Go1.20 Dec 15, 2022
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/458016 mentions this issue: os/exec: retry ETXTBSY errors in TestFindExecutableVsNoexec

@bcmills
Copy link
Contributor

bcmills commented Dec 15, 2022

I made this test parallel in CL 439196, which is what exposed it to #22315 — so this is technically a minor regression.

@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels Dec 15, 2022
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Dec 15, 2022
@gopherbot gopherbot moved this to Done in Test Flakes Dec 16, 2022
@golang golang locked and limited conversation to collaborators Dec 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bcmills bcmills

Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Archived in project
Milestone
Go1.20
Development

No branches or pull requests
2 participants
@bcmills @gopherbot